Resolve stable manifest url during agent update when using stable keyword

cr: https://code.amazon.com/reviews/CR-100238454

Author: VishnuKarthikRavindran

agent/update/processor/processor.go

@@ -292,11 +292,12 @@ func determineTarget(mgr *updateManager, logger log.T, updateDetail *UpdateDetai
 		var stableVersionUrl string
 		updateDetail.TargetResolver = updateconstants.TargetVersionStable
 		logger.Info("TargetVersion is 'stable', attempting to get the stable version from s3")
-		stableVersionUrl, err = getStableManifestURL(updateDetail.ManifestURL)
+		stableVersionUrl, err = getStableManifestURL(updateDetail.ManifestURL, mgr.Context.Identity())
 		if err != nil {
 			// Should never happen because manifest has already been downloaded using the manifest url at this point
 			return mgr.failed(updateDetail, logger, updateconstants.ErrorGetStableVersionS3, fmt.Sprintf("Failed to generate stable version from manifest url: %v", err), true)
 		}
+
 		updateDetail.TargetVersion, err = mgr.S3util.GetStableVersion(stableVersionUrl)
 		if err != nil {
 			return mgr.failed(updateDetail, logger, updateconstants.ErrorGetStableVersionS3, fmt.Sprintf("Failed to get stable version form s3: %v", err), true)

agent/update/processor/processor_test.go

@@ -26,6 +26,8 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/aws/amazon-ssm-agent/common/identity"
+
 	"github.com/aws/amazon-ssm-agent/agent/appconfig"
 	"github.com/aws/amazon-ssm-agent/agent/context"
 	"github.com/aws/amazon-ssm-agent/agent/contracts"
@@ -578,7 +580,7 @@ func TestDetermineTarget_TargetVersionStable_FailedGetStableURL(t *testing.T) {
 		finalizeCalled = true
 		return nil
 	}
-	getStableManifestURL = func(manifestURL string) (string, error) {
+	getStableManifestURL = func(manifestURL string, identity identity.IAgentIdentity) (string, error) {
 		return "", fmt.Errorf("err1")
 	}
 	finalizeCalled = false
@@ -589,9 +591,6 @@ func TestDetermineTarget_TargetVersionStable_FailedGetStableURL(t *testing.T) {
 	assert.True(t, finalizeCalled)
 	assert.Contains(t, tempCode, string(updateconstants.ErrorGetStableVersionS3))
 	assert.True(t, updateconstants.TargetVersionStable == updateDetail.TargetResolver)
-
-	getStableManifestURL = updateutil.GetManifestURLFromSourceUrl
-
 }
 
 func TestDetermineTarget_TargetVersionStable_FailedGetStableVersion(t *testing.T) {

agent/updateutil/updateutil.go

@@ -740,12 +740,19 @@ func GetManifestURLFromSourceUrl(sourceURL string) (string, error) {
 	return u.String(), nil
 }
 
-func GetStableURLFromManifestURL(manifestURL string) (string, error) {
+func GetStableURLFromManifestURL(manifestURL string, identity identity.IAgentIdentity) (string, error) {
 	if !strings.HasSuffix(manifestURL, "/"+updateconstants.ManifestFile) {
 		return "", fmt.Errorf("unexpected manifest url does not end with manifest file: %s", manifestURL)
 	}
+	stableVersionPath := "stable/VERSION"
+	region, err := identity.Region()
+	if err != nil {
+		return "", err
+	}
 
-	return strings.TrimRight(manifestURL, updateconstants.ManifestFile) + "stable/VERSION", nil
+	stableVersionURL := strings.TrimRight(manifestURL, updateconstants.ManifestFile) + stableVersionPath
+	stableVersionURL = strings.Replace(stableVersionURL, updateconstants.RegionHolder, region, -1)
+	return stableVersionURL, nil
 }
 
 // ResolveAgentReleaseBucketURL makes best effort to generate an url for the ssm agent bucket

agent/updateutil/updateutil_test.go

@@ -477,27 +477,35 @@ func TestCompareVersion(t *testing.T) {
 
 func TestGetStableURLFromManifestURL(t *testing.T) {
 	// Empty URL
-	url, err := GetStableURLFromManifestURL("")
+	agentIdentity := identityMocks.NewDefaultMockAgentIdentity()
+	agentIdentity.On("Region").Return("us-east-1", nil)
+
+	url, err := GetStableURLFromManifestURL("", agentIdentity)
 	assert.Error(t, err)
 	assert.Equal(t, "", url)
 
 	// Invalid URL
-	url, err = GetStableURLFromManifestURL("InvalidUrl")
+	url, err = GetStableURLFromManifestURL("InvalidUrl", agentIdentity)
 	assert.Error(t, err)
 	assert.Equal(t, "", url)
 
 	// Invalid manifest url - artifact url
-	url, err = GetStableURLFromManifestURL("https://bucket.s3.region.amazonaws.com/amazon-ssm-agent/version/amazon-ssm-agent.tar.gz")
+	url, err = GetStableURLFromManifestURL("https://bucket.s3.region.amazonaws.com/amazon-ssm-agent/version/amazon-ssm-agent.tar.gz", agentIdentity)
 	assert.Error(t, err)
 	assert.Equal(t, "", url)
 
+	// Prod manifest url with region placeholder
+	url, err = GetStableURLFromManifestURL("https://s3.{Region}.amazonaws.com/amazon-ssm-{Region}/ssm-agent-manifest.json", agentIdentity)
+	assert.NoError(t, err)
+	assert.Equal(t, "https://s3.us-east-1.amazonaws.com/amazon-ssm-us-east-1/stable/VERSION", url)
+
 	// Valid s3 manifest link bucket in Path
-	url, err = GetStableURLFromManifestURL("https://s3.region.amazonaws.com/bucket/ssm-agent-manifest.json")
+	url, err = GetStableURLFromManifestURL("https://s3.region.amazonaws.com/bucket/ssm-agent-manifest.json", agentIdentity)
 	assert.NoError(t, err)
 	assert.Equal(t, "https://s3.region.amazonaws.com/bucket/stable/VERSION", url)
 
 	// Valid s3 manifest link with bucket in url
-	url, err = GetStableURLFromManifestURL("https://bucket.s3.region.amazonaws.com/ssm-agent-manifest.json")
+	url, err = GetStableURLFromManifestURL("https://bucket.s3.region.amazonaws.com/ssm-agent-manifest.json", agentIdentity)
 	assert.NoError(t, err)
 	assert.Equal(t, "https://bucket.s3.region.amazonaws.com/stable/VERSION", url)
 }