Skip to content

Commit 3dff39d

Browse files
HaoranRENadchalla
authored andcommitted
Fix an inaccurate log when validating allowDowngrade parameter during Agent update
cr: https://code.amazon.com/reviews/CR-123693017
1 parent 664e02b commit 3dff39d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

agent/update/processor/processor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ func validateUpdateParam(mgr *updateManager, logger log.T, updateDetail *UpdateD
354354

355355
if !updateDetail.AllowDowngrade {
356356
logger.Warnf("Downgrade is not enabled, please enable downgrade to perform this update")
357-
return mgr.failed(updateDetail, logger, updateconstants.ErrorAttemptToDowngrade, fmt.Sprintf("Updating %v to an older version, please enable allow downgrade to proceed", updateDetail.TargetVersion), true)
357+
return mgr.failed(updateDetail, logger, updateconstants.ErrorAttemptToDowngrade, fmt.Sprintf("Updating %v to an older version %v, please enable allow downgrade to proceed", updateDetail.SourceVersion, updateDetail.TargetVersion), true)
358358
}
359359
}
360360

agent/update/processor/processor_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ func TestValidateUpdateParam_FailedAttemptDowngrade_AllowDowngradeFalse(t *testi
939939
assert.Equal(t, contracts.ResultStatusFailed, updateDetail.Result)
940940
assert.True(t, updateDetail.RequiresUninstall)
941941

942-
assert.Contains(t, updateDetail.StandardOut, "to an older version, please enable allow downgrade to proceed")
942+
assert.Contains(t, updateDetail.StandardOut, "Updating 3.0.0.0 to an older version 2.0.0.0, please enable allow downgrade to proceed")
943943
assert.Equal(t, "", updateDetail.StandardError)
944944
}
945945

0 commit comments

Comments
 (0)