Skip to content

Commit 52fdddf

Browse files
JingyiAWSVishnuKarthikRavindran
authored andcommitted
Handling more S3 VPC endpoint patterns
cr: https://code.amazon.com/reviews/CR-106240944
1 parent ddb9418 commit 52fdddf

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

agent/s3util/s3uri.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,16 @@ const (
3030
"(bucket|accesspoint|control)\\.vpce-[-a-z0-9]+\\." + // VPC endpoint DNS name
3131
"s3[.-]" + // S3 service name
3232
"(([-a-z0-9]+)\\.)?" + // region name, optional for us-east-1
33-
"vpce\\.amazonaws\\.com"
33+
"vpce\\." +
34+
"(amazonaws\\.com|c2s\\.ic\\.gov|sc2s\\.sgov\\.gov)"
3435
vpceUrlPatternBucketIdx = 2
3536
vpceUrlPatternRegionIdx = 5
3637

3738
// Regex for S3 URLs, public S3 endpoint
3839
nonVpceUrlPattern = "^((.+)\\.)?" + // maybe a bucket name
3940
"s3[.-](website[-.])?(accelerate\\.)?(dualstack[-.])?" + // S3 service name with optional features
4041
"(([-a-z0-9]+)\\.)?" + // region name, optional for us-east-1
41-
"amazonaws\\.com"
42+
"(amazonaws\\.com|c2s\\.ic\\.gov|sc2s\\.sgov\\.gov)"
4243
nonVpceUrlPatternBucketIdx = 2
4344
nonVpceUrlPatternRegionIdx = 7
4445

agent/s3util/s3uri_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ var (
3131
sslTests = []s3BucketTest{
3232
// {bucket, url, AmazonS3URL{IsValidS3URI, IsPathStyle, Bucket, Key, Region}},
3333
{"abc", "https://abc.s3.mock-region.amazonaws.com/", AmazonS3URL{true, false, "abc", "", "mock-region"}},
34+
{"abc", "https://abc.s3.mock-region.c2s.ic.gov/", AmazonS3URL{true, false, "abc", "", "mock-region"}},
35+
{"abc", "https://abc.s3.mock-region.sc2s.sgov.gov/", AmazonS3URL{true, false, "abc", "", "mock-region"}},
3436
{"a$b$c", "https://s3.mock-region.amazonaws.com/a%24b%24c", AmazonS3URL{true, true, "a$b$c", "", "mock-region"}},
3537
{"a.b.c", "https://s3.mock-region.amazonaws.com/a.b.c", AmazonS3URL{true, true, "a.b.c", "", "mock-region"}},
3638
{"a..bc", "https://s3.mock-region.amazonaws.com/a..bc", AmazonS3URL{true, true, "a..bc", "", "mock-region"}},
@@ -194,6 +196,28 @@ var (
194196
"us-gov-west-1",
195197
},
196198
},
199+
{
200+
"mybucket",
201+
"https://bucket.vpce-07dd6fec74b812c52-2gqlpwuc.s3.us-iso-east-1.vpce.c2s.ic.gov/mybucket/mykey",
202+
AmazonS3URL{
203+
true,
204+
true,
205+
"mybucket",
206+
"mykey",
207+
"us-iso-east-1",
208+
},
209+
},
210+
{
211+
"mybucket",
212+
"https://bucket.vpce-07dd6fec74b812c52-2gqlpwuc.s3.us-isob-east-1.vpce.sc2s.sgov.gov/mybucket/mykey",
213+
AmazonS3URL{
214+
true,
215+
true,
216+
"mybucket",
217+
"mykey",
218+
"us-isob-east-1",
219+
},
220+
},
197221
}
198222
)
199223

0 commit comments

Comments
 (0)