required code changes

Author: mrgrain

packages/@aws-cdk/cloud-assembly-schema/test/integ-tests.test.ts

@@ -27,7 +27,7 @@ describe('Integration test', () => {
                   notificationArns: ['arn1', 'arn2'],
                   execute: true,
                   parameters: {
-                    MYPARAM: 'Value',
+                    'MYPARAM': 'Value',
                     'Stack1:OtherParam': 'OtherValue',
                   },
                   usePreviousParameters: true,

packages/@aws-cdk/node-bundle/src/api/_attributions.ts

@@ -48,7 +48,6 @@ export interface AttributionsProps {
  * `Attributions` represents an attributions file containing third-party license information.
  */
 export class Attributions {
-
   private readonly packageDir: string;
   private readonly packageName: string;
   private readonly dependencies: Package[];
@@ -79,7 +78,6 @@ export class Attributions {
    * This method never throws. The Caller is responsible for inspecting the report returned and act accordinagly.
    */
   public validate(): ViolationsReport {
-
     const violations: Violation[] = [];
     const relNoticePath = path.relative(this.packageDir, this.filePath);
 
@@ -124,7 +122,6 @@ export class Attributions {
   }
 
   private render(attributions: Map<string, Attribution>): string {
-
     const content = [];
 
     if (attributions.size > 0) {
@@ -152,11 +149,9 @@ export class Attributions {
       // endings, so we standardize to LF.
       .map(l => l.replace(/\r\n/g, '\n'))
       .join('\n');
-
   }
 
   private generateAttributions(): Map<string, Attribution> {
-
     if (this.dependencies.length === 0) {
       return new Map();
     }
@@ -216,7 +211,6 @@ export class Attributions {
 
     return attributions;
   }
-
 }
 
 /**

packages/@aws-cdk/node-bundle/src/api/bundle.ts

@@ -176,7 +176,6 @@ export interface Externals {
  * Bundle class to validate and pack nodejs bundles.
  */
 export class Bundle {
-
   private readonly manifest: any;
   private readonly noticePath: string;
 
@@ -239,7 +238,6 @@ export class Bundle {
    * returned report and act accordingly.
    */
   public validate(options: BundleValidateOptions = {}): ViolationsReport {
-
     const fix = options.fix ?? false;
 
     // first validate
@@ -270,7 +268,6 @@ export class Bundle {
    * Returns the temp directory location.
    */
   public write(): string {
-
     const target = fs.mkdtempSync(path.join(os.tmpdir(), 'bundle-write-'));
 
     // we definitely don't need these directories in the package
@@ -302,7 +299,6 @@ export class Bundle {
    * Returns the location of the tarball.
    */
   public pack(options: BundlePackOptions = {}): string {
-
     const target = options.target ?? this.packageDir;
 
     const report = this.validate();
@@ -324,7 +320,6 @@ export class Bundle {
     console.log('Writing bundle');
     const bundleDir = this.write();
     try {
-
       if (this.test) {
         const command = `${path.join(bundleDir, this.test)}`;
         console.log(`Running sanity test: ${command}`);
@@ -385,7 +380,6 @@ export class Bundle {
   }
 
   private findExternalDependencyVersion(name: string): string {
-
     const versions = new Set<string>();
 
     // external dependencies will not exist in the dependencies list
@@ -418,7 +412,6 @@ export class Bundle {
   }
 
   private closestPackagePath(fdp: string): string {
-
     if (fs.existsSync(path.join(fdp, 'package.json'))) {
       return fdp;
     }
@@ -437,7 +430,6 @@ export class Bundle {
   }
 
   private esbuild(): esbuild.BuildResult {
-
     const bundle = esbuild.buildSync({
       entryPoints: this.entryPoints,
       bundle: true,
@@ -506,7 +498,6 @@ export class Bundle {
   }
 
   private addExternals(manifest: any) {
-
     // external dependencies should be specified as runtime dependencies
     for (const external of this.externals.dependencies ?? []) {
       const version = this.findExternalDependencyVersion(external);
@@ -520,7 +511,6 @@ export class Bundle {
       manifest.optionalDependencies = manifest.optionalDependencies ?? {};
       manifest.optionalDependencies[external] = version;
     }
-
   }
 
   private removeDependencies(manifest: any) {
@@ -551,7 +541,6 @@ export class Bundle {
 }
 
 function longestCommonParent(paths: string[]) {
-
   function _longestCommonParent(p1: string, p2: string): string {
     const dirs1 = p1.split(path.sep);
     const dirs2 = p2.split(path.sep);

packages/@aws-cdk/node-bundle/src/api/index.ts

@@ -1,2 +1,2 @@
 export * from './bundle';
-export * from './violation';
+export * from './violation';

packages/@aws-cdk/node-bundle/src/api/violation.ts

@@ -63,7 +63,6 @@ export interface Violation {
  * Report encapsulating a list of violations.
  */
 export class ViolationsReport {
-
   constructor(private readonly _violations: Violation[]) {}
 
   /**
@@ -92,5 +91,4 @@ export class ViolationsReport {
     }
     return summary.join('\n');
   }
-
 }

packages/@aws-cdk/node-bundle/src/index.ts

@@ -1 +1 @@
-export * from './api';
+export * from './api';

packages/@aws-cdk/node-bundle/test/_package.ts

@@ -34,7 +34,6 @@ export interface PackageOptions {
  * Generate packages for test scenarios.
  */
 export class Package {
-
   /**
    * Create a package.
    */
@@ -47,7 +46,7 @@ export class Package {
 
     if (options.licenses?.length === 1) {
       manifest.license = options.licenses[0];
-    };
+    }
 
     if (options.licenses && options.licenses.length > 1) {
       manifest.licenses = options.licenses!.map(l => ({ type: l }));
@@ -159,5 +158,4 @@ export class Package {
     }
     fs.removeSync(this.dir);
   }
-
-}
+}

packages/@aws-cdk/node-bundle/test/api/bundle.test.ts

@@ -4,7 +4,6 @@ import { Bundle } from '../../src';
 import { Package } from '../_package';
 
 test('validate', () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'], circular: true });
   const dep1 = pkg.addDependency({ name: 'dep1', licenses: ['INVALID'] });
   const dep2 = pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0', 'MIT'] });
@@ -31,7 +30,6 @@ test('validate', () => {
 });
 
 test('write', () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -58,11 +56,9 @@ test('write', () => {
   const manifest = fs.readJSONSync(path.join(bundleDir, 'package.json'));
 
   expect(manifest.dependencies).toEqual({});
-
 });
 
 test('pack', () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   const dep1 = pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   const dep2 = pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -95,11 +91,9 @@ test('pack', () => {
 
   const tarball = path.join(pkg.dir, `${pkg.name}-${pkg.version}.tgz`);
   expect(fs.existsSync(tarball)).toBeTruthy();
-
 });
 
 test('validate and fix', () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -125,11 +119,9 @@ test('validate and fix', () => {
   bundle.pack();
   const tarball = path.join(pkg.dir, `${pkg.name}-${pkg.version}.tgz`);
   expect(fs.existsSync(tarball)).toBeTruthy();
-
 });
 
 test('write ignores only .git and node_modules directories', () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -153,5 +145,4 @@ test('write ignores only .git and node_modules directories', () => {
 
   expect(fs.existsSync(path.join(bundleDir, '.gitignore'))).toBeTruthy();
   expect(fs.existsSync(path.join(bundleDir, 'node_modules_file'))).toBeTruthy();
-
 });

packages/@aws-cdk/node-bundle/test/cli.test.ts

@@ -5,7 +5,6 @@ import { Package } from './_package';
 import { cliMain } from '../src/cli-main';
 
 test('validate', async () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'], circular: true });
   const dep1 = pkg.addDependency({ name: 'dep1', licenses: ['INVALID'] });
   const dep2 = pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0', 'MIT'] });
@@ -32,11 +31,9 @@ test('validate', async () => {
     ]);
     expect(violations).toEqual(expected);
   }
-
 });
 
 test('write', async () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -63,11 +60,9 @@ test('write', async () => {
   const manifest = fs.readJSONSync(path.join(bundleDir, 'package.json'));
 
   expect(manifest.dependencies).toEqual({});
-
 });
 
 test('validate and fix', async () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -97,11 +92,9 @@ test('validate and fix', async () => {
   await run(['pack']);
   const tarball = path.join(pkg.dir, `${pkg.name}-${pkg.version}.tgz`);
   expect(fs.existsSync(tarball)).toBeTruthy();
-
 });
 
 test('pack', async () => {
-
   const pkg = Package.create({ name: 'consumer', licenses: ['Apache-2.0'] });
   const dep1 = pkg.addDependency({ name: 'dep1', licenses: ['MIT'] });
   const dep2 = pkg.addDependency({ name: 'dep2', licenses: ['Apache-2.0'] });
@@ -134,7 +127,6 @@ test('pack', async () => {
 
   const tarball = path.join(pkg.dir, `${pkg.name}-${pkg.version}.tgz`);
   expect(fs.existsSync(tarball)).toBeTruthy();
-
 });
 
 async function runCliMain(cwd: string, command: string[]): Promise<string> {
@@ -155,4 +147,4 @@ async function runCliMain(cwd: string, command: string[]): Promise<string> {
     process.chdir(curdir);
     spy.mockRestore();
   }
-}
+}

packages/@aws-cdk/yarn-cling/lib/index.ts

@@ -250,7 +250,6 @@ export function checkRequiredVersions(root: PackageLock | PackageLockPackage) {
   function recurse(entry: PackageLock | PackageLockPackage, parentChain: PackageLockEntry[]) {
     // On the root, 'requires' is the value 'true', for God knows what reason. Don't care about those.
     if (typeof entry.requires === 'object') {
-
       // For every 'requires' dependency, find the version it actually got resolved to and compare.
       for (const [name, range] of Object.entries(entry.requires)) {
         const resolvedPackage = findResolved(name, [entry, ...parentChain]);