Skip to content

Commit 209d10e

Browse files
committed
chore: make logs artifacts unique per matrix job
We used to try to upload all logs under the same artifact name, but we need to make them explicitly unique per matrix job otherwise the names collide. Also include a link to the artifact name in the summary, just for kicks.
1 parent f12ec97 commit 209d10e

File tree

5 files changed

+22
-12
lines changed

5 files changed

+22
-12
lines changed

.github/workflows/integ.yml

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/cloud-assembly-schema/tsconfig.dev.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projenrc/cdk-cli-integ-tests.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,19 +422,26 @@ export class CdkCliIntegTestsWorkflow extends Component {
422422
{
423423
name: 'Set workflow summary',
424424
run: [
425-
'echo "## Test results" >> $GITHUB_STEP_SUMMARY',
426425
'cat logs/md/*.md >> $GITHUB_STEP_SUMMARY',
427426
].join('\n'),
428427
},
429428
{
430429
name: 'Upload logs',
431430
uses: 'actions/[email protected]',
431+
id: 'logupload',
432432
with: {
433-
name: 'logs',
433+
name: 'logs-${{ matrix.suite }}',
434434
path: 'logs/',
435435
overwrite: 'true',
436436
},
437437
},
438+
{
439+
name: 'Append artifact URL',
440+
run: [
441+
'echo "" >> $GITHUB_STEP_SUMMARY',
442+
'echo "[Logs](${{ steps.logupload.outputs.artifact-url }})" >> $GITHUB_STEP_SUMMARY',
443+
].join('\n'),
444+
},
438445
],
439446
});
440447

tsconfig.dev.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tsconfig.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)