Skip to content

Commit 455c017

Browse files
authored
fix: skipLibCheck is not turned on for all init templates (#800)
This makes TypeScript check whether all provided type files are coherent, which is taking more and more time as the CDK is growing. Turning this off greatly decreases type checking and compilation times. See: https://devblogs.microsoft.com/typescript/announcing-typescript-5-9/#minimal-and-updated-tsc---init --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent 093e5a6 commit 455c017

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

packages/aws-cdk/lib/init-templates/app/typescript/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"inlineSources": true,
2121
"experimentalDecorators": true,
2222
"strictPropertyInitialization": false,
23+
"skipLibCheck": true,
2324
"typeRoots": [
2425
"./node_modules/@types"
2526
]

packages/aws-cdk/lib/init-templates/lib/typescript/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"inlineSources": true,
2121
"experimentalDecorators": true,
2222
"strictPropertyInitialization": false,
23+
"skipLibCheck": true,
2324
"typeRoots": [
2425
"./node_modules/@types"
2526
]

packages/aws-cdk/lib/init-templates/sample-app/javascript/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
"allowJs": true,
2323
"checkJs": true,
2424
"noEmit": true,
25+
"skipLibCheck": true,
2526
"typeRoots": [
2627
"./node_modules/@types"
2728
]

packages/aws-cdk/lib/init-templates/sample-app/typescript/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"inlineSources": true,
2121
"experimentalDecorators": true,
2222
"strictPropertyInitialization": false,
23+
"skipLibCheck": true,
2324
"typeRoots": [
2425
"./node_modules/@types"
2526
]

0 commit comments

Comments
 (0)