Skip to content

Commit 48244a9

Browse files
authored
chore: mask bucket name in s3 docs publishing step (#182)
Actually mask the bucket name in s3 docs publishing logs. This isn't a secret, so it's not bad. The logs for the one run that did accidentally print the name have already been deleted. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent f8d28e0 commit 48244a9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projenrc/s3-docs-publishing.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export class S3DocsPublishing extends Component {
9595
DOCS_STREAM: this.props.docsStream,
9696
},
9797
run: [
98-
'::add-mask::$BUCKET_NAME', // always hide bucket name
98+
'echo ::add-mask::$BUCKET_NAME', // always hide bucket name
9999

100100
// setup paths
101101
`echo "S3_PATH=$DOCS_STREAM/${safeName}-v$(cat dist/version.txt).zip" >> "$GITHUB_ENV"`,

0 commit comments

Comments
 (0)