chore(cli): lint test files

Author: mrgrain

.projenrc.ts

@@ -1002,6 +1002,8 @@ const cli = configureProject(
       '@types/sinon',
       '@types/yargs@^15',
       'aws-cdk-lib',
+      'aws-sdk-client-mock',
+      'aws-sdk-client-mock-jest',
       'axios',
       'constructs',
       'fast-check',
@@ -1097,7 +1099,7 @@ const cli = configureProject(
     },
     eslintOptions: {
       dirs: ['lib'],
-      ignorePatterns: ['*.template.ts', '*.d.ts', 'test/**/*.ts'],
+      ignorePatterns: ['*.template.ts', '*.d.ts'],
     },
     jestOptions: jestOptionsForProject({
       jestConfig: {
@@ -1144,6 +1146,7 @@ cli.eslint?.addOverride({
   files: ['./test/**'],
   rules: {
     '@cdklabs/no-throw-default-error': 'off',
+    '@typescript-eslint/unbound-method': 'off',
   },
 });
 

packages/aws-cdk/.eslintrc.json

@@ -3,12 +3,12 @@ import * as path from 'path';
 import { ArtifactMetadataEntryType, ArtifactType, type AssetManifest, type AssetMetadataEntry, type AwsCloudFormationStackProperties, type MetadataEntry, type MissingContext } from '@aws-cdk/cloud-assembly-schema';
 import { type CloudAssembly, CloudAssemblyBuilder, type CloudFormationStackArtifact, type StackMetadata } from '@aws-cdk/cx-api';
 import { cxapiAssemblyWithForcedVersion } from './assembly-versions';
-import { MockSdkProvider } from '../_helpers/mock-sdk';
-import { CloudExecutable } from '../../lib/cxapp/cloud-executable';
-import { Configuration } from '../../lib/cli/user-configuration';
 import { TestIoHost } from './io-host';
-import { IIoHost } from '../../lib/cli/io-host';
 import { asIoHelper } from '../../../@aws-cdk/toolkit-lib/lib/api/io/private';
+import type { IIoHost } from '../../lib/cli/io-host';
+import { Configuration } from '../../lib/cli/user-configuration';
+import { CloudExecutable } from '../../lib/cxapp/cloud-executable';
+import { MockSdkProvider } from '../_helpers/mock-sdk';
 
 export const DEFAULT_FAKE_TEMPLATE = { No: 'Resources' };
 
@@ -47,7 +47,7 @@ export class MockCloudExecutable extends CloudExecutable {
     const configuration = new Configuration();
     const sdkProvider = sdkProviderArg ?? new MockSdkProvider();
     const mockIoHost = ioHost ?? new TestIoHost();
-    
+
     super({
       configuration,
       sdkProvider,

packages/aws-cdk/.projen/deps.json

@@ -1,4 +1,4 @@
-import { IIoHost, IoMessage, IoMessageLevel, IoRequest } from "../../../@aws-cdk/toolkit-lib/lib/api/io";
+import type { IIoHost, IoMessage, IoMessageLevel, IoRequest } from '../../../@aws-cdk/toolkit-lib/lib/api/io';
 
 /**
  * An implementation of `IIoHost` that records messages and lets you assert on what was logged

packages/aws-cdk/.projen/tasks.json

@@ -3,7 +3,7 @@
  * A Jest environment that buffers outputs to `console.log()` and only shows it for failing tests.
  */
 import type { EnvironmentContext, JestEnvironment, JestEnvironmentConfig } from '@jest/environment';
-import { Circus } from '@jest/types';
+import type { Circus } from '@jest/types';
 import { TestEnvironment as NodeEnvironment } from 'jest-environment-node';
 
 interface ConsoleMessage {

packages/aws-cdk/package.json

@@ -63,7 +63,9 @@ afterAll(async () => {
     await new Promise<void>((resolve, reject) => {
       const response = aft(resolve as any);
       if (isPromise(response)) {
-        response.then(() => { return resolve(); }, reject);
+        response.then(() => {
+          return resolve();
+        }, reject);
       } else {
         resolve();
       }

packages/aws-cdk/test/_helpers/assembly.ts

@@ -1,8 +1,9 @@
 import 'aws-sdk-client-mock-jest';
-import { Environment } from '@aws-cdk/cx-api';
+import type { Environment } from '@aws-cdk/cx-api';
 import { AppSyncClient } from '@aws-sdk/client-appsync';
 import { CloudControlClient } from '@aws-sdk/client-cloudcontrol';
-import { CloudFormationClient, Stack, StackStatus } from '@aws-sdk/client-cloudformation';
+import type { Stack } from '@aws-sdk/client-cloudformation';
+import { CloudFormationClient, StackStatus } from '@aws-sdk/client-cloudformation';
 import { CloudWatchLogsClient } from '@aws-sdk/client-cloudwatch-logs';
 import { CodeBuildClient } from '@aws-sdk/client-codebuild';
 import { EC2Client } from '@aws-sdk/client-ec2';
@@ -19,12 +20,12 @@ import { SFNClient } from '@aws-sdk/client-sfn';
 import { SSMClient } from '@aws-sdk/client-ssm';
 import { AssumeRoleCommand, GetCallerIdentityCommand, STSClient } from '@aws-sdk/client-sts';
 import { createCredentialChain } from '@aws-sdk/credential-providers';
-import { AwsCredentialIdentity } from '@smithy/types';
+import type { AwsCredentialIdentity } from '@smithy/types';
 import { mockClient } from 'aws-sdk-client-mock';
 import { type Account } from 'cdk-assets';
+import { TestIoHost } from './io-host';
 import { SDK, SdkProvider } from '../../lib/api/aws-auth';
 import { CloudFormationStack } from '../../lib/api/cloudformation';
-import { TestIoHost } from './io-host';
 
 export const FAKE_CREDENTIALS: AwsCredentialIdentity = {
   accessKeyId: 'ACCESS',
@@ -98,7 +99,7 @@ export const restoreSdkMocksToDefault = () => {
  */
 export function undoAllSdkMocks() {
   applyToAllMocks('restore');
-};
+}
 
 function applyToAllMocks(meth: 'reset' | 'restore') {
   mockAppSyncClient[meth]();