Skip to content

Commit 6c5bf3f

Browse files
authored
Merge branch 'main' into conroy/labels
2 parents 3163d4e + f925551 commit 6c5bf3f

21 files changed

+183
-30
lines changed

.gitallowed

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# The only AWS account number allowed to be used in tests (used by git-secrets)
2+
account = '123456789012';
3+
# account used for cross-environment tests in addition to the one above
4+
account: '234567890123'
5+
# Account patterns used in the README
6+
account: '000000000000'
7+
account: '111111111111'
8+
account: '222222222222'
9+
account: '333333333333'
10+
11+
# used in physical names tests in @aws-cdk/core
12+
account: '012345678912'
13+
account: '012345678913'
14+
15+
# Account patterns used in the CHANGELOG
16+
account: '123456789012'
17+
18+
111111111111
19+
222222222222
20+
123456789012
21+
333333333333
22+
23+
# The account ID's of public facing ECR images for App Mesh Envoy
24+
# https://docs.aws.amazon.com/app-mesh/latest/userguide/envoy.html
25+
account: '772975370895'
26+
account: '856666278305'
27+
account: '840364872350'
28+
account: '422531588944'
29+
account: '924023996002'
30+
account: '919366029133' #cn-north-1
31+
account: '919830735681' #cn-northwest-1
32+
account: '909464085924' #ap-southeast-3
33+
account: '564877687649' #il-central-1
34+
35+
# The account IDs of password rotation applications of Serverless Application Repository
36+
# https://docs.aws.amazon.com/secretsmanager/latest/userguide/enable-rotation-rds.html
37+
# partition aws
38+
account: '297356227824'
39+
# partition aws-cn
40+
account: '193023089310'
41+
# partition aws-us-gov
42+
account: '023102451235'

.github/workflows/release.yml

Lines changed: 8 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.gitignore

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projen/tasks.json

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projenrc.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ const repoProject = new yarn.Monorepo({
184184

185185
workflowNodeVersion: 'lts/*',
186186
workflowRunsOn,
187-
gitignore: ['.DS_Store'],
187+
gitignore: ['.DS_Store', '.tools'],
188188

189189
autoApproveUpgrades: true,
190190
autoApproveOptions: {
@@ -216,6 +216,7 @@ const repoProject = new yarn.Monorepo({
216216
},
217217
},
218218
},
219+
219220
buildWorkflowOptions: {
220221
preBuildSteps: [
221222
// Need this for the init tests
@@ -242,11 +243,23 @@ repoProject.eslint = new pj.javascript.Eslint(repoProject, {
242243
fileExtensions: ['.ts', '.tsx'],
243244
lintProjenRc: false,
244245
});
246+
245247
// always lint projen files as part of the build
246248
if (repoProject.eslint?.eslintTask) {
247249
repoProject.tasks.tryFind('build')?.spawn(repoProject.eslint?.eslintTask);
248250
}
249251

252+
// always scan for git secrets before building
253+
const gitSecretsScan = repoProject.addTask('git-secrets-scan', {
254+
steps: [
255+
{
256+
exec: '/bin/bash ./projenrc/git-secrets-scan.sh',
257+
},
258+
],
259+
});
260+
261+
repoProject.tasks.tryFind('build')!.spawn(gitSecretsScan);
262+
250263
new AdcPublishing(repoProject);
251264

252265
const repo = configureProject(repoProject);

package.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/toolkit-lib/CODE_REGISTRY.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@
33
| Code | Description | Level | Data Interface |
44
|------|-------------|-------|----------------|
55
| CDK_TOOLKIT_I1000 | Provides synthesis times. | info | n/a |
6-
| CDK_TOOLKIT_I1901 | Provides stack data | result | [StackData](docs/interfaces/StackData.html) |
7-
| CDK_TOOLKIT_I1902 | Successfully deployed stacks | result | [AssemblyData](docs/interfaces/AssemblyData.html) |
6+
| CDK_TOOLKIT_I1901 | Provides stack data | result | [StackData](https://docs.aws.amazon.com/cdk/api/toolkit-lib/interfaces/StackData.html) |
7+
| CDK_TOOLKIT_I1902 | Successfully deployed stacks | result | [AssemblyData](https://docs.aws.amazon.com/cdk/api/toolkit-lib/interfaces/AssemblyData.html) |
88
| CDK_TOOLKIT_I2901 | Provides details on the selected stacks and their dependencies | result | n/a |
99
| CDK_TOOLKIT_E3900 | Resource import failed | error | n/a |
1010
| CDK_TOOLKIT_I5000 | Provides deployment times | info | n/a |
11-
| CDK_TOOLKIT_I5001 | Provides total time in deploy action, including synth and rollback | info | [Duration](docs/interfaces/Duration.html) |
11+
| CDK_TOOLKIT_I5001 | Provides total time in deploy action, including synth and rollback | info | [Duration](https://docs.aws.amazon.com/cdk/api/toolkit-lib/interfaces/Duration.html) |
1212
| CDK_TOOLKIT_I5002 | Provides time for resource migration | info | n/a |
1313
| CDK_TOOLKIT_I5031 | Informs about any log groups that are traced as part of the deployment | info | n/a |
1414
| CDK_TOOLKIT_I5050 | Confirm rollback during deployment | info | n/a |
1515
| CDK_TOOLKIT_I5060 | Confirm deploy security sensitive changes | info | n/a |
16-
| CDK_TOOLKIT_I5900 | Deployment results on success | result | [SuccessfulDeployStackResult](docs/interfaces/SuccessfulDeployStackResult.html) |
16+
| CDK_TOOLKIT_I5900 | Deployment results on success | result | [SuccessfulDeployStackResult](https://docs.aws.amazon.com/cdk/api/toolkit-lib/interfaces/SuccessfulDeployStackResult.html) |
1717
| CDK_TOOLKIT_E5001 | No stacks found | error | n/a |
1818
| CDK_TOOLKIT_I6000 | Provides rollback times | info | n/a |
1919
| CDK_TOOLKIT_E6001 | No stacks found | error | n/a |

packages/@aws-cdk/toolkit-lib/lib/api/io/io-message.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { ToolkitAction } from '../../toolkit';
77
export type IoMessageLevel = 'error'| 'result' | 'warn' | 'info' | 'debug' | 'trace';
88

99
/**
10-
* A valid message code
10+
* A valid message code. See https://github.com/aws/aws-cdk-cli/blob/main/packages/%40aws-cdk/toolkit-lib/CODE_REGISTRY.md
1111
*/
1212
export type IoMessageCode = `CDK_${string}_${'E' | 'W' | 'I'}${number}${number}${number}${number}`;
1313

packages/@aws-cdk/toolkit-lib/scripts/gen-code-registry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function codesToMarkdownTable(codes: Record<string, CodeInfo>, mdPrefix?: string
1919
}
2020

2121
function linkInterface(interfaceName: string) {
22-
const docSite = 'docs/interfaces/';
22+
const docSite = 'https://docs.aws.amazon.com/cdk/api/toolkit-lib/interfaces/';
2323
return `[${interfaceName}](${docSite}${interfaceName}.html)`;
2424
}
2525

packages/aws-cdk/README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,21 @@ The AWS CDK Toolkit provides the `cdk` command-line interface that can be used t
3939

4040
This module is part of the [AWS Cloud Development Kit](https://github.com/aws/aws-cdk) project.
4141

42+
## Global Options
43+
44+
### `unstable`
45+
46+
The `--unstable` flag indicates that the scope and API of a feature might still change.
47+
Otherwise the feature is generally production ready and fully supported. For example,
48+
`cdk gc` is gated behind an `--unstable` flag:
49+
50+
```bash
51+
cdk gc --unstable=gc
52+
```
53+
54+
The command will fail if `--unstable=gc` is not passed in, which acknowledges that the user
55+
is aware of the caveats in place for the feature.
56+
4257
## Commands
4358

4459
### `cdk docs`

0 commit comments

Comments
 (0)