update call

Author: kaizencc

packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/proxy/cdk-requests-go-through-a-proxy-when-configured.integtest.ts

@@ -30,7 +30,7 @@ integTest('requests go through a proxy when configured',
 
       const connections = JSON.parse(await fs.readFile(path.join(cdkCacheDir, 'connection.json'), 'utf8'));
       // eslint-disable-next-line no-console
-      console.log(connections);
+      console.log('connections', connections);
 
       const requests = await proxyServer.getSeenRequests();
       const urls = requests.map(req => req.url);

packages/@aws-cdk/toolkit-lib/lib/api/notices/web-data-source.ts

@@ -58,7 +58,7 @@ export class WebsiteNoticeDataSource implements NoticeDataSource {
   async fetch(): Promise<Notice[]> {
     if (!this.skipNetworkCache) {
       await this.ioHelper.notify({
-        message: `website data source fetch starting, ${JSON.stringify(this.agent)}`,
+        message: `website data source fetch starting, ${this.agent !== undefined}}`,
         time: new Date(Date.now()),
         level: 'info',
         data: undefined,

packages/@aws-cdk/toolkit-lib/lib/util/network-detector.ts

@@ -46,6 +46,7 @@ export class NetworkDetector {
   }
 
   private static readonly TIMEOUT_MS = 500;
+  private static readonly URL = 'https://cli.cdk.dev-tools.aws.dev/notices.json';
 
   private static async load(): Promise<CachedConnectivity> {
     const defaultValue = {
@@ -73,9 +74,7 @@ export class NetworkDetector {
 
   private static ping(agent?: https.Agent): Promise<boolean> {
     return new Promise((resolve) => {
-      const req = https.request({
-        hostname: 'cli.cdk.dev-tools.aws.dev',
-        path: '/notices.json',
+      const req = https.request(NetworkDetector.URL, {
         method: 'HEAD',
         agent,
         timeout: this.TIMEOUT_MS,

packages/@aws-cdk/toolkit-lib/test/util/network-detector.test.ts

@@ -31,8 +31,8 @@ describe('NetworkDetector', () => {
       destroy: jest.fn(),
     };
 
-    mockRequest.mockImplementation((_options, callback) => {
-      callback({ statusCode: 200 });
+    mockRequest.mockImplementation((_url, _options, callback) => {
+      setTimeout(() => callback({ statusCode: 200 }), 0);
       return mockReq;
     });
 
@@ -51,8 +51,8 @@ describe('NetworkDetector', () => {
       destroy: jest.fn(),
     };
 
-    mockRequest.mockImplementation((_options, callback) => {
-      callback({ statusCode: 500 });
+    mockRequest.mockImplementation((_url, _options, callback) => {
+      setTimeout(() => callback({ statusCode: 500 }), 0);
       return mockReq;
     });
 
@@ -109,8 +109,8 @@ describe('NetworkDetector', () => {
       destroy: jest.fn(),
     };
 
-    mockRequest.mockImplementation((_options, callback) => {
-      callback({ statusCode: 200 });
+    mockRequest.mockImplementation((_url, _options, callback) => {
+      setTimeout(() => callback({ statusCode: 200 }), 0);
       return mockReq;
     });
 
@@ -132,8 +132,8 @@ describe('NetworkDetector', () => {
       destroy: jest.fn(),
     };
 
-    mockRequest.mockImplementation((_options, callback) => {
-      callback({ statusCode: 200 });
+    mockRequest.mockImplementation((_url, _options, callback) => {
+      setTimeout(() => callback({ statusCode: 200 }), 0);
       return mockReq;
     });
 
@@ -152,8 +152,8 @@ describe('NetworkDetector', () => {
       destroy: jest.fn(),
     };
 
-    mockRequest.mockImplementation((_options, callback) => {
-      callback({ statusCode: 200 });
+    mockRequest.mockImplementation((_url, _options, callback) => {
+      setTimeout(() => callback({ statusCode: 200 }), 0);
       return mockReq;
     });