Skip to content

Commit ba59816

Browse files
fix: chokidar and npm rely on outdated version of tar (#1059)
Fixes internal issue. Gets us off of tar mv 6 by upgrading chokidar from v3 -> v4 (used by `cdk watch`), and npm from v10 -> v11 (used by `cli-integ`) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 78ed91b commit ba59816

File tree

18 files changed

+698
-1337
lines changed

18 files changed

+698
-1337
lines changed

.projenrc.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -867,7 +867,7 @@ const toolkitLib = configureProject(
867867
'archiver',
868868
'cdk-from-cfn',
869869
'chalk@^4',
870-
'chokidar@^3',
870+
'chokidar@^4',
871871
'fast-deep-equal',
872872
'fs-extra@^9',
873873
'glob',
@@ -1191,7 +1191,7 @@ const cli = configureProject(
11911191
cdkAssetsLib,
11921192
'cdk-from-cfn',
11931193
'chalk@^4',
1194-
'chokidar@^3',
1194+
'chokidar@^4',
11951195
'decamelize@^5', // Non-ESM
11961196
'enquirer',
11971197
'fs-extra@^9',
@@ -1370,11 +1370,6 @@ for (const resourceCommand of includeCliResourcesCommands) {
13701370
}
13711371

13721372
new BundleCli(cli, {
1373-
externals: {
1374-
optionalDependencies: [
1375-
'fsevents',
1376-
],
1377-
},
13781373
allowedLicenses: BUNDLED_LICENSES,
13791374
dontAttribute: '^@aws-cdk/|^@cdklabs/|^cdk-assets$|^cdk-cli-wrapper$',
13801375
test: 'bin/cdk --version',
@@ -1481,7 +1476,7 @@ const integRunner = configureProject(
14811476
cloudFormationDiff.customizeReference({ versionType: 'exact' }),
14821477
toolkitLib.customizeReference({ versionType: 'exact' }),
14831478
'workerpool@^6',
1484-
'chokidar@^3',
1479+
'chokidar@^4',
14851480
'chalk@^4',
14861481
'fs-extra@^9',
14871482
'yargs@^16',
@@ -1539,9 +1534,6 @@ new TypecheckTests(integRunner);
15391534

15401535
new BundleCli(integRunner, {
15411536
externals: {
1542-
optionalDependencies: [
1543-
'fsevents',
1544-
],
15451537
dependencies: [
15461538
'@aws-cdk/aws-service-spec',
15471539
'aws-cdk',
@@ -1599,7 +1591,7 @@ const cliInteg = configureProject(
15991591
'glob@^9',
16001592
'make-runnable@^1',
16011593
'mockttp@^3',
1602-
'npm@^10',
1594+
'npm@^11',
16031595
'p-queue@^6',
16041596
'semver@^7',
16051597
'sinon@^9',

packages/@aws-cdk-testing/cli-integ/.projen/deps.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/cli-integ/package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/integ-runner/.projen/deps.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/integ-runner/.projen/tasks.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)