Skip to content

Commit e8904b8

Browse files
rix0rrrgithub-actions
andauthored
chore: fix jsii publishing in a monorepo (#71)
We were cd'ing into the wrong directories. The current mechanism builds jsii packages as part of the release step. This is good because it saves time (they all get built in parallel, and it's not part of the regular build), but it's bad because if one of them fails then it'll be hard to fix and retry. Not sure what to make of this; currently we build jsii packages both at build time and at release time, which is extra silly. We'll have to pick one. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent bfb1ff4 commit e8904b8

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

.github/workflows/release.yml

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projenrc/jsii.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,11 +504,11 @@ export class JsiiBuild extends pj.Component {
504504
},
505505
{
506506
name: `Create ${target} artifact`,
507-
run: `cd ${REPO_TEMP_DIRECTORY} && ${this.tsProject.runTaskCommand(packTask)}`,
507+
run: `cd ${REPO_TEMP_DIRECTORY}/${this.monoProject.workspaceDirectory} && ${this.tsProject.runTaskCommand(packTask)}`,
508508
},
509509
{
510510
name: `Collect ${target} artifact`,
511-
run: `mv ${REPO_TEMP_DIRECTORY}/${this.tsProject.artifactsDirectory} ${this.tsProject.artifactsDirectory}`,
511+
run: `mv ${REPO_TEMP_DIRECTORY}/${this.monoProject.workspaceDirectory}/${this.tsProject.artifactsDirectory} ${this.tsProject.artifactsDirectory}`,
512512
},
513513
);
514514

0 commit comments

Comments
 (0)