From 12c64867b01335d1bcb8e3752516e0dfd4ab6f9f Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Wed, 5 Mar 2025 18:21:45 +0000 Subject: [PATCH] chore(cli): remove unused destroy options --- .../@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts | 2 +- packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts | 1 - packages/aws-cdk/lib/api/deployments/deploy-stack.ts | 2 -- packages/aws-cdk/lib/api/deployments/deployments.ts | 5 ----- packages/aws-cdk/lib/cli/cdk-toolkit.ts | 9 --------- packages/aws-cdk/lib/cli/cli.ts | 1 - 6 files changed, 1 insertion(+), 19 deletions(-) diff --git a/packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts b/packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts index f68cc332f..3a9862048 100644 --- a/packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts +++ b/packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts @@ -14,7 +14,7 @@ export interface DestroyOptions { /** * Change stack watcher output to CI mode. * - * @deprecated Implement in IoHost instead + * @deprecated has no effect, please implement in IoHost instead */ readonly ci?: boolean; } diff --git a/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts b/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts index 510fa3ec9..ee2e3ef59 100644 --- a/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts +++ b/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts @@ -738,7 +738,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab stack, deployName: stack.stackName, roleArn: options.roleArn, - ci: options.ci, }); await ioHost.notify(success(`\n ✅ ${chalk.blue(stack.displayName)}: ${action}ed`)); } catch (e) { diff --git a/packages/aws-cdk/lib/api/deployments/deploy-stack.ts b/packages/aws-cdk/lib/api/deployments/deploy-stack.ts index 9e2bfbb62..451833f93 100644 --- a/packages/aws-cdk/lib/api/deployments/deploy-stack.ts +++ b/packages/aws-cdk/lib/api/deployments/deploy-stack.ts @@ -664,8 +664,6 @@ export interface DestroyStackOptions { sdk: SDK; roleArn?: string; deployName?: string; - quiet?: boolean; - ci?: boolean; } export async function destroyStack(options: DestroyStackOptions, { ioHost, action }: IoMessaging) { diff --git a/packages/aws-cdk/lib/api/deployments/deployments.ts b/packages/aws-cdk/lib/api/deployments/deployments.ts index e6b366dbd..331c9ca4e 100644 --- a/packages/aws-cdk/lib/api/deployments/deployments.ts +++ b/packages/aws-cdk/lib/api/deployments/deployments.ts @@ -278,9 +278,6 @@ export interface DestroyStackOptions { stack: cxapi.CloudFormationStackArtifact; deployName?: string; roleArn?: string; - quiet?: boolean; - force?: boolean; - ci?: boolean; } export interface StackExistsOptions { @@ -590,8 +587,6 @@ export class Deployments { roleArn: executionRoleArn, stack: options.stack, deployName: options.deployName, - quiet: options.quiet, - ci: options.ci, }, { ioHost: this.ioHost, action: this.action }); } diff --git a/packages/aws-cdk/lib/cli/cdk-toolkit.ts b/packages/aws-cdk/lib/cli/cdk-toolkit.ts index 92b1d8174..03ad73c77 100644 --- a/packages/aws-cdk/lib/cli/cdk-toolkit.ts +++ b/packages/aws-cdk/lib/cli/cdk-toolkit.ts @@ -382,7 +382,6 @@ export class CdkToolkit { force: true, roleArn: options.roleArn, fromDeploy: true, - ci: options.ci, }); } return; @@ -857,7 +856,6 @@ export class CdkToolkit { stack, deployName: stack.stackName, roleArn: options.roleArn, - ci: options.ci, }); success(`\n ✅ %s: ${action}ed`, chalk.blue(stack.displayName)); } catch (e) { @@ -1699,13 +1697,6 @@ export interface DestroyOptions { * Whether the destroy request came from a deploy. */ fromDeploy?: boolean; - - /** - * Whether we are on a CI system - * - * @default false - */ - readonly ci?: boolean; } /** diff --git a/packages/aws-cdk/lib/cli/cli.ts b/packages/aws-cdk/lib/cli/cli.ts index 6d77b2e79..aabe5ed44 100644 --- a/packages/aws-cdk/lib/cli/cli.ts +++ b/packages/aws-cdk/lib/cli/cli.ts @@ -428,7 +428,6 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise