refactor(cli): settings doesn't log anymore#267
Merged
Conversation
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 85.29% 85.12% -0.17%
==========================================
Files 220 220
Lines 36619 36627 +8
Branches 4458 4437 -21
==========================================
- Hits 31234 31179 -55
- Misses 5288 5352 +64
+ Partials 97 96 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
approved these changes
Mar 20, 2025
mrgrain
force-pushed
the
mrgrain/refactor/settings-no-logging
branch
from
a16b9e7 to
a64858d
Compare
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/refactor/settings-no-logging
branch
from
a64858d to
f0279c8
Compare
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes logging from the
Settingsclass. Logging was only used when loading settings from a file and that functionality is currently only used by theUserConfigurationclass of the CLI. So I localized the loading there. If we wanted to re-introduce a generic loading from file in the future, we just need to build it with theIoHostin mind.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license