Skip to content

Commit 28ba12a

Browse files
authored
Merge branch 'main' into merge-back/2.174.1
2 parents f353fc7 + ac3ffa5 commit 28ba12a

File tree

134 files changed

+36105
-811
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+36105
-811
lines changed

CONTRIBUTORS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ Shout out to our top contributors!
1313
- [otaviomacedo](https://github.com/otaviomacedo)
1414
- [mrgrain](https://github.com/mrgrain)
1515
- [pahud](https://github.com/pahud)
16-
- [TheRealAmazonKendra](https://github.com/TheRealAmazonKendra)
16+
- [mazyu36](https://github.com/mazyu36)
1717
- [comcalvi](https://github.com/comcalvi)
18+
- [TheRealAmazonKendra](https://github.com/TheRealAmazonKendra)
1819
- [madeline-k](https://github.com/madeline-k)
19-
- [mazyu36](https://github.com/mazyu36)
2020
- [go-to-k](https://github.com/go-to-k)
2121
- [NetaNir](https://github.com/NetaNir)
22-
- [robertd](https://github.com/robertd)
2322
- [badmintoncryer](https://github.com/badmintoncryer)
23+
- [robertd](https://github.com/robertd)
2424
- [MrArnoldPalmer](https://github.com/MrArnoldPalmer)
2525
- [lpizzinidev](https://github.com/lpizzinidev)
2626
- [peterwoodworth](https://github.com/peterwoodworth)
@@ -29,4 +29,4 @@ Shout out to our top contributors!
2929
- [watany-dev](https://github.com/watany-dev)
3030

3131

32-
_Last updated: Sun, 01 Dec 24 00:14:16 +0000_
32+
_Last updated: Wed, 01 Jan 25 00:12:26 +0000_

codecov.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,4 @@ component_management:
3737
# https://docs.codecov.com/docs/ignoring-paths
3838
ignore:
3939
- packages/aws-cdk/lib/cli.ts # we integ test this file
40+
- ^(?!.*packages\/(aws-cdk|aws-cdk-lib\/core)\/).+$ # ignore anything that isn't in the cli or core

packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2634,6 +2634,20 @@ integTest('hotswap ECS deployment respects properties override', withDefaultFixt
26342634
expect(describeServicesResponse.services?.[0].deploymentConfiguration?.maximumPercent).toEqual(ecsMaximumHealthyPercent);
26352635
}));
26362636

2637+
integTest('cdk destroy does not fail even if the stacks do not exist', withDefaultFixture(async (fixture) => {
2638+
const nonExistingStackName1 = 'non-existing-stack-1';
2639+
const nonExistingStackName2 = 'non-existing-stack-2';
2640+
2641+
await expect(fixture.cdkDestroy([nonExistingStackName1, nonExistingStackName2])).resolves.not.toThrow();
2642+
}));
2643+
2644+
integTest('cdk destroy with no force option exits without prompt if the stacks do not exist', withDefaultFixture(async (fixture) => {
2645+
const nonExistingStackName1 = 'non-existing-stack-1';
2646+
const nonExistingStackName2 = 'non-existing-stack-2';
2647+
2648+
await expect(fixture.cdk(['destroy', ...fixture.fullStackName([nonExistingStackName1, nonExistingStackName2])])).resolves.not.toThrow();
2649+
}));
2650+
26372651
async function listChildren(parent: string, pred: (x: string) => Promise<boolean>) {
26382652
const ret = new Array<string>();
26392653
for (const child of await fs.readdir(parent, { encoding: 'utf-8' })) {
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)