chore: upgrade to new eslint and switch to flat config (#36272)

Centralize eslint config in a new package, `@aws-cdk/eslint-config` as well because it was duplicated too much.

Addresses linting/compilation problems that had gone unnoticed because of nonstandard package configs.

- Since the version of `@stylistic/eslint-plugin` that supports flat config forces a move to ESM. Since Node 18 doesn't yet support `require()`ing ESM modules and since config loading needs to be synchronous, our config has to run as ESM.
- Rename `.eslintrc.js` -> `eslint.config.mjs` everywhere for the new flat config (and update `.gitignore` and `.npmignore` at the same time)
- Introduce `@aws-cdk/eslint-config` to hold a centralized config for all packages in the monorepo.
- Found some `.bak` files that seem like they're just hanging out.
- Update all packages with `eslint --fix` to the new sets of rules.
- Custom resource handler tests were not being type checked and had a bunch of issues that needed to be fixed.
- `quote-props` -> `@stylistic/quote-props`
- Bulk suppressions for the `Error` rule in dedicated files, because the eslint tool doesn't allow adding suppression comments in bulk.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: rix0rrr

lerna.json

@@ -9,6 +9,7 @@
     "packages/@aws-cdk-containers/*",
     "packages/@aws-cdk-testing/*",
     "packages/@aws-cdk/*/lambda-packages/*",
+    "tools/@aws-cdk/eslint-config",
     "tools/@aws-cdk/cdk-build-tools",
     "tools/@aws-cdk/user-input-gen",
     "tools/@aws-cdk/cdk-release",

package.json

@@ -80,6 +80,7 @@
       "packages/awslint",
       "packages/@aws-cdk-testing/*",
       "packages/@aws-cdk/*/lambda-packages/*",
+      "tools/@aws-cdk/eslint-config",
       "tools/@aws-cdk/cdk-build-tools",
       "tools/@aws-cdk/user-input-gen",
       "tools/@aws-cdk/cdk-release",

packages/@aws-cdk-testing/framework-integ/.eslintrc.js

@@ -4,7 +4,7 @@
 .LAST_BUILD
 *.snk
 junit.xml
-!.eslintrc.js
+!eslint.config.mjs
 .nyc_output
 coverage
 nyc.config.js

packages/@aws-cdk-testing/framework-integ/.gitignore

@@ -2,6 +2,6 @@
 .LAST_BUILD
 *.snk
 junit.xml
-.eslintrc.js
+eslint.config.mjs
 # exclude cdk artifacts
 **/cdk.out

packages/@aws-cdk-testing/framework-integ/.npmignore

@@ -0,0 +1,11 @@
+import { makeConfig } from '@aws-cdk/eslint-config';
+
+const config = makeConfig('tsconfig.json');
+for (const c of config) {
+    // Disable import/order rule, it's being violated all over the place
+    if (c.rules) {
+        c.rules['import/order'] = ['off'];
+    }
+}
+
+export default config;

packages/@aws-cdk-testing/framework-integ/eslint.config.mjs

@@ -0,0 +1,8 @@
+{
+  "Description": "foo bar",
+  "Resources": {
+    "TopicProductD757E287": {
+      "Type": "AWS::SNS::Topic"
+    }
+  }
+}

packages/@aws-cdk-testing/framework-integ/jest.config.js.bak

@@ -0,0 +1,7 @@
+{
+  "Resources": {
+    "TopicProductD757E287": {
+      "Type": "AWS::SNS::Topic"
+    }
+  }
+}

packages/@aws-cdk-testing/framework-integ/product-stack-snapshots/integservicecatalogproductProductStackHistory4D520FF1.integservicecatalogproductSNSTopicProduct3B51CF591.v1.product.template.json

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 
 export const handler = async (event: AWSLambda.APIGatewayProxyEventV2) => {
   const key = event.headers['x-api-key'];