Skip to content

Commit dca8663

Browse files
authored
chore: update dev dependency - aws-sdk-js-codemod (#34542)
### Issue # (if applicable) Closes #31755. ### Reason for this change The dev dependency is outdated and creates issue for users wanting to use some of the aws-sdk packages in custom resources. ### Description of changes <!-- What code changes did you make? Have you made any important design decisions? What AWS use cases does this change enable? To enable the use cases, which AWS service features are utilized? --> The goal of this change is to update the outdated `aws-sdk-js-codemod` package to the latest available version (bumping the major version from 0.x.x to 2.x.x). The following changes have been made: 1. Updated the `aws-sdk-js-codemod` 1. Ran scripts/update-sdkv3-parameters-model.sh 1. Fixed incorrect IAM prefix generated for CloudWatch actions, see #33078 and doc: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/permissions-reference-cw.html 1. Set the feature flag `logApiResponseDataPropertyTrueDefault` to false (which is the default value) for the tests that needed a snapshot update, as there is a bug that causes the snapshots to be outdated: #30583 1. Ran the tests with `--update-on-failed` to update snasphots 1. Reverted the feature flag changes. ### Description of how you validated changes Ran the integration tests and updated the snapshots. - `framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.oidc.ts`: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with `--dry-run --force` - `packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.template.json`: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with `--dry-run --force` ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 parents f4dc7e2 + 9460749 commit dca8663

File tree

147 files changed

+124258
-123301
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

147 files changed

+124258
-123301
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"@types/node": "18.11.19",
2020
"@types/prettier": "2.6.0",
2121
"@yarnpkg/lockfile": "^1.1.0",
22-
"aws-sdk-js-codemod": "^0.28.2",
22+
"aws-sdk-js-codemod": "^2.4.5",
2323
"cdk-generate-synthetic-examples": "^0.2.26",
2424
"conventional-changelog-cli": "^2.2.2",
2525
"fs-extra": "^9.1.0",

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/asset.2b2f6e7d96d216685951807694b6e6fca88b8fd0f6ac90be6d3c75201710dd6a/index.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876/index.js

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 137 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.assets.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@
827827
"S3Bucket": {
828828
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
829829
},
830-
"S3Key": "695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876.zip"
830+
"S3Key": "2b2f6e7d96d216685951807694b6e6fca88b8fd0f6ac90be6d3c75201710dd6a.zip"
831831
},
832832
"Handler": "index.handler",
833833
"Role": {

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integtestcognitoDefaultTestDeployAssert6F2623C9.assets.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integtestcognitoDefaultTestDeployAssert6F2623C9.template.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/manifest.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/tree.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)