-
Hello, Would it be possible to add Thanks in advance. |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments
-
Hi Robert, Do you have examples of cases where you were interested in something, would have expected to find it in the change log, but didn't? My instinctual reaction is that these other commits are not user visible, and therefore shouldn't be included into the CHANGELOG (I know,
Well... by that point every single commit will lead to a line in the CHANGELOG. So wouldn't digging through the change log be equivalent to digging through the commit history at that point? 🤓 I have a feeling there's a more specific question behind the question. It might help to look at examples? |
Beta Was this translation helpful? Give feedback.
-
Sometimes things get deprecated and they slip under the radar. We often see reverts that are
Perhaps having a full blown changelog between versions vs highlights-only changelog for release (with bug fixes and features only) would be an option.
Haha... touché 🤣 All in all, I'm just thinking out loud what would be the best course of action to get all the changes in one place that builds on top of Conventional Commits (https://www.conventionalcommits.org/en/v1.0.0/). Anyway, treat this as random ramblings from a fellow contributor... nothing else 😄 |
Beta Was this translation helpful? Give feedback.
-
In response to these examples:
Reverts may be Neither of these should be the case, so if that happens we need to explain the PR naming rules a bit better inside the team. I'll take that up. |
Beta Was this translation helpful? Give feedback.
-
Makes sense. Frankly, the more I think about this the more I lean toward
using `git log —oneline` and grep-ing around and finding what I need
between the releases. Thanks for chiming in and bringing me to my (common)
senses Rico :)
…On Mon, Mar 13, 2023 at 1:25 AM Rico Hermans ***@***.***> wrote:
In response to these examples:
Sometimes things get deprecated and they slip under the radar.
We often see reverts that are chore related.
Reverts *may* be chores, but only if the change they are reverting hasn't
been released yet. In that case, the revert isn't user-impacting. If the
change has been released, then it should become a fix like any other.
Neither of these *should* be the case, so if that happens we need to
explain the PR naming rules a bit better inside the team. I'll take that up.
—
Reply to this email directly, view it on GitHub
<#24559 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHWN3TIHVD35YTZJFYH4LW33KX5ANCNFSM6AAAAAAVV7EHRY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
Hello! Reopening this discussion to make it searchable. |
Beta Was this translation helpful? Give feedback.
In response to these examples:
Reverts may be
chore
s, but only if the change they are reverting hasn't been released yet. In that case, the revert isn't user-impacting. If the change has been released, then it should become afix
like any other.Neither of these should be the case, so if that happens we need to explain the PR naming rules a bit better inside the team. I'll take that up.