Private NPM Dependency Support

[AlexTech314]

In regards to: aws-lambda-nodejs

This is a cool construct for sure, but a big use case that is missing is the ability to use a private NPM registry. This requires some hack work, such as this snippet from my project:

new nodejs.NodejsFunction(this, 'InviteProviderHandler', {
     bundling: {
       forceDockerBundling: true,
       nodeModules: ['dotenv', 'aws-sdk', '@caralyst/bootstrap-sequelize'],
       externalModules: ['aws-sdk'],
       network: 'host',
       securityOpt: 'no-new-privileges',
       user: 'root',
       logLevel: nodejs.LogLevel.INFO,
       commandHooks: {
         beforeBundling(_inputDir: string, _outputDir: string): string[] {
           return []
         },
         afterBundling(_inputDir: string, _outputDir: string): string[] {
           return [];
         },
         beforeInstall() {
           return [
             `npm config set "@caralyst:registry" https://npm.pkg.github.com`,
             `npm config set "//npm.pkg.github.com/:_authToken" <hardcoded token w/ only read permissions>`
           ];
         },
       }
     },
     depsLockFilePath: './lambda/invite-provider-handler/package-lock.json',
     entry: 'lambda/invite-provider-handler/invite_provider.js',
     handler: 'handler',
     vpc: vpc,
     vpcSubnets: {
       subnetType: SubnetType.PRIVATE_WITH_EGRESS
     },
     securityGroups: [securityGroup],
   });

Notice my use of the beforeInstall() hook. This is fine in theory, but it does not work with tokens. Therefore, I need to literal string value of my token which I'd prefer to not expose. If this construct allowed for setting a a registry for a namespace and an auth token (that can be a TOKEN, not a raw string), that would make it perfect. Would love to hear if anyone else agrees/has found a workaround!

Cheers,
Alex

Editing: Maybe this is not possible since the assets need to bundle before deployment...

[AlexTech314]

Answering my own question:

I'll use AWS CodeArtifact to host my private npm dependencies. This way I can configure access using IAM roles rather than a github access token.

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.