Skip to content

Commit 46e2fb3

Browse files
author
Rakshil Modi
committed
Fixed failing test case
1 parent a7426e8 commit 46e2fb3

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

awscli/customizations/s3/subcommands.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1272,21 +1272,17 @@ def create_instructions(self):
12721272
instruction list because it sends the request to S3 and does not
12731273
yield anything.
12741274
"""
1275-
# TODO #rhm : optimize this
12761275
if self.needs_versiongenerator():
12771276
self.instructions.append('versioned_file_generator')
1278-
else:
1279-
if self.needs_filegenerator():
1280-
self.instructions.append('file_generator')
1281-
self.instructions.append('file_info_builder')
1282-
1283-
# Add common processing instructions that apply to both generators
1284-
if self.needs_filegenerator() or self.needs_versiongenerator():
1277+
if self.parameters.get('filters'):
1278+
self.instructions.append('filters')
1279+
elif self.needs_filegenerator():
1280+
self.instructions.append('file_generator')
12851281
if self.parameters.get('filters'):
12861282
self.instructions.append('filters')
12871283
if self.cmd == 'sync':
12881284
self.instructions.append('comparator')
1289-
1285+
self.instructions.append('file_info_builder')
12901286
self.instructions.append('s3_handler')
12911287

12921288
def needs_versiongenerator(self):

0 commit comments

Comments
 (0)