Overridding sync strategy

Author: Rakshil Modi

awscli/customizations/s3/subcommands.py

@@ -40,7 +40,6 @@
     NeverSync,
     SizeAndLastModifiedSync,
 )
-from awscli.customizations.s3.syncstrategy.nooverwrite import NoOverwriteSync
 from awscli.customizations.s3.utils import (
     AppendFilter,
     RequestParamsMapper,
@@ -1297,15 +1296,10 @@ def choose_sync_strategies(self):
         of its self when the event is emitted.
         """
         sync_strategies = {}
-        if self.parameters.get('no_overwrite'):
-            sync_strategies['file_at_src_and_dest_sync_strategy'] = (
-                NoOverwriteSync()
-            )
-        else:
-            # Set the default strategies.
-            sync_strategies['file_at_src_and_dest_sync_strategy'] = (
-                SizeAndLastModifiedSync()
-            )
+        # Set the default strategies.
+        sync_strategies['file_at_src_and_dest_sync_strategy'] = (
+            SizeAndLastModifiedSync()
+        )
         sync_strategies['file_not_at_dest_sync_strategy'] = MissingFileSync()
         sync_strategies['file_not_at_src_sync_strategy'] = NeverSync()
 
@@ -1320,7 +1314,6 @@ def choose_sync_strategies(self):
                     sync_type = override_sync_strategy.sync_type
                     sync_type += '_sync_strategy'
                     sync_strategies[sync_type] = override_sync_strategy
-
         return sync_strategies
 
     def run(self):

awscli/customizations/s3/syncstrategy/nooverwrite.py

@@ -12,6 +12,7 @@
 # language governing permissions and limitations under the License.
 import logging
 
+from awscli.customizations.s3.subcommands import NO_OVERWRITE
 from awscli.customizations.s3.syncstrategy.base import BaseSync
 
 LOG = logging.getLogger(__name__)
@@ -24,6 +25,8 @@ class NoOverwriteSync(BaseSync):
     overwriting of existing files, regardless of size or modification time differences.
     """
 
+    ARGUMENT = NO_OVERWRITE
+
     def determine_should_sync(self, src_file, dest_file):
         LOG.debug(
             f"warning: skipping {src_file.src} -> {src_file.dest}, file exists at destination"