Skip to content

Commit e087ce6

Browse files
authored
Merge pull request #7776 from aws/dependabot/pip/v2/prompt-toolkit-gte-3.0.24-and-lt-3.0.39
Update prompt-toolkit requirement from <3.0.29,>=3.0.24 to >=3.0.24,<3.0.39
2 parents bf6e8ac + 84d9cf5 commit e087ce6

File tree

9 files changed

+40
-26
lines changed

9 files changed

+40
-26
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"type": "enhancement",
3+
"category": "dependency",
4+
"description": "Bump upper bound of prompt-toolkit to <3.0.39"
5+
}

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ dependencies = [
3737
# a consistent dependency closure across all Python versions,
3838
# we explicitly include ruamel.yaml.clib as a dependency.
3939
"ruamel.yaml.clib>=0.2.0,<=0.2.7",
40-
"prompt-toolkit>=3.0.24,<3.0.29",
40+
"prompt-toolkit>=3.0.24,<3.0.39",
4141
"distro>=1.5.0,<1.9.0",
4242
"awscrt>=0.12.4,<0.17.0",
4343
"python-dateutil>=2.1,<3.0.0",

requirements/download-deps/portable-exe-lock.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ macholib==1.16.2 \
151151
--hash=sha256:44c40f2cd7d6726af8fa6fe22549178d3a4dfecc35a9cd15ea916d9c83a688e0 \
152152
--hash=sha256:557bbfa1bb255c20e9abafe7ed6cd8046b48d9525db2f9b77d3122a63a2a8bf8
153153
# via pyinstaller
154-
prompt-toolkit==3.0.28 \
155-
--hash=sha256:30129d870dcb0b3b6a53efdc9d0a83ea96162ffd28ffe077e94215b233dc670c \
156-
--hash=sha256:9f1cd16b1e86c2968f2519d7fb31dd9d669916f515612c269d14e9ed52b51650
154+
prompt-toolkit==3.0.38 \
155+
--hash=sha256:23ac5d50538a9a38c8bde05fecb47d0b403ecd0662857a86f886f798563d5b9b \
156+
--hash=sha256:45ea77a2f7c60418850331366c81cf6b5b9cf4c7fd34616f733c5427e6abbb1f
157157
# via awscli (pyproject.toml)
158158
pycparser==2.21 \
159159
--hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \

requirements/download-deps/portable-exe-win-lock.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,9 @@ pefile==2023.2.7 \
149149
--hash=sha256:82e6114004b3d6911c77c3953e3838654b04511b8b66e8583db70c65998017dc \
150150
--hash=sha256:da185cd2af68c08a6cd4481f7325ed600a88f6a813bad9dea07ab3ef73d8d8d6
151151
# via pyinstaller
152-
prompt-toolkit==3.0.28 \
153-
--hash=sha256:30129d870dcb0b3b6a53efdc9d0a83ea96162ffd28ffe077e94215b233dc670c \
154-
--hash=sha256:9f1cd16b1e86c2968f2519d7fb31dd9d669916f515612c269d14e9ed52b51650
152+
prompt-toolkit==3.0.38 \
153+
--hash=sha256:23ac5d50538a9a38c8bde05fecb47d0b403ecd0662857a86f886f798563d5b9b \
154+
--hash=sha256:45ea77a2f7c60418850331366c81cf6b5b9cf4c7fd34616f733c5427e6abbb1f
155155
# via awscli (pyproject.toml)
156156
pycparser==2.21 \
157157
--hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \

requirements/download-deps/system-sandbox-lock.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@ jmespath==1.0.1 \
141141
--hash=sha256:02e2e4cc71b5bcab88332eebf907519190dd9e6e82107fa7f83b1003a6252980 \
142142
--hash=sha256:90261b206d6defd58fdd5e85f478bf633a2901798906be2ad389150c5c60edbe
143143
# via awscli (pyproject.toml)
144-
prompt-toolkit==3.0.28 \
145-
--hash=sha256:30129d870dcb0b3b6a53efdc9d0a83ea96162ffd28ffe077e94215b233dc670c \
146-
--hash=sha256:9f1cd16b1e86c2968f2519d7fb31dd9d669916f515612c269d14e9ed52b51650
144+
prompt-toolkit==3.0.38 \
145+
--hash=sha256:23ac5d50538a9a38c8bde05fecb47d0b403ecd0662857a86f886f798563d5b9b \
146+
--hash=sha256:45ea77a2f7c60418850331366c81cf6b5b9cf4c7fd34616f733c5427e6abbb1f
147147
# via awscli (pyproject.toml)
148148
pycparser==2.21 \
149149
--hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \

requirements/download-deps/system-sandbox-win-lock.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@ jmespath==1.0.1 \
141141
--hash=sha256:02e2e4cc71b5bcab88332eebf907519190dd9e6e82107fa7f83b1003a6252980 \
142142
--hash=sha256:90261b206d6defd58fdd5e85f478bf633a2901798906be2ad389150c5c60edbe
143143
# via awscli (pyproject.toml)
144-
prompt-toolkit==3.0.28 \
145-
--hash=sha256:30129d870dcb0b3b6a53efdc9d0a83ea96162ffd28ffe077e94215b233dc670c \
146-
--hash=sha256:9f1cd16b1e86c2968f2519d7fb31dd9d669916f515612c269d14e9ed52b51650
144+
prompt-toolkit==3.0.38 \
145+
--hash=sha256:23ac5d50538a9a38c8bde05fecb47d0b403ecd0662857a86f886f798563d5b9b \
146+
--hash=sha256:45ea77a2f7c60418850331366c81cf6b5b9cf4c7fd34616f733c5427e6abbb1f
147147
# via awscli (pyproject.toml)
148148
pycparser==2.21 \
149149
--hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \

tests/conftest.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ def clear_loggers():
3939

4040
@pytest.fixture
4141
def ptk_app_session():
42-
pipe_input = create_pipe_input()
43-
output = DummyOutput()
44-
try:
45-
with create_app_session(input=pipe_input, output=output) as session:
46-
yield session
47-
finally:
48-
pipe_input.close()
42+
with create_pipe_input() as pipe_input:
43+
output = DummyOutput()
44+
try:
45+
with create_app_session(input=pipe_input, output=output) as session:
46+
yield session
47+
finally:
48+
pipe_input.close()

tests/functional/autoprompt/test_prompttoolkit.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,11 @@ class TestPromptToolkitPrompterBuffer:
158158
def test_input_buffer_initialization(
159159
self, prompter, args, expected_input_buffer_text):
160160
prompter.args = args
161-
prompter.pre_run()
162-
actual_input_text = prompter.input_buffer.document.text
163-
assert actual_input_text == expected_input_buffer_text
161+
app_runner = PromptToolkitAppRunner(
162+
app=prompter.app, pre_run=prompter.pre_run)
163+
with app_runner.run_app_in_thread():
164+
actual_input_text = prompter.input_buffer.document.text
165+
assert actual_input_text == expected_input_buffer_text
164166

165167
def test_handle_args_with_spaces(self, app_runner, prompter):
166168
original_args = ['iam', 'create-role', '--description', 'With spaces']
@@ -241,8 +243,10 @@ def test_doc_buffer_keeps_position_if_content_dont_change(
241243
)
242244
def test_doc_panel_content(self, prompter, args, expected_docs):
243245
prompter.args = args
244-
prompter.pre_run()
245-
assert expected_docs in prompter.doc_buffer.document.text
246+
app_runner = PromptToolkitAppRunner(
247+
app=prompter.app, pre_run=prompter.pre_run)
248+
with app_runner.run_app_in_thread():
249+
assert expected_docs in prompter.doc_buffer.document.text
246250

247251

248252
class TestHistoryMode(BasicPromptToolkitTest):

tests/unit/autoprompt/test_factory.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
from awscli.testutils import unittest
2525

2626

27+
class FakeCLIPromptBuffer(CLIPromptBuffer):
28+
def start_completion(self):
29+
pass
30+
31+
2732
class TestPromptToolkitFactory(unittest.TestCase):
2833
def setUp(self):
2934
self.factory = PromptToolkitFactory(completer=DummyCompleter())
@@ -84,7 +89,7 @@ def test_can_create_key_bindings(self):
8489

8590
class TestCLIPromptBuffer(unittest.TestCase):
8691
def setUp(self):
87-
self.buffer = CLIPromptBuffer()
92+
self.buffer = FakeCLIPromptBuffer()
8893

8994
def test_history_mode_switching(self):
9095
self.buffer.switch_history_mode()

0 commit comments

Comments
 (0)