Skip to content

Conversation

sushilk123
Copy link

Add CLI examples for Amazon Macie2 core commands

Description

Adds missing CLI examples for Amazon Macie2 security service commands to improve documentation coverage.

Changes

  • Add enable-macie example showing basic enablement and custom configuration options
  • Add get-findings example showing security finding retrieval and filtering capabilities
  • Add create-classification-job example for one-time and scheduled data classification jobs
  • Improves documentation coverage for Amazon Macie2 service from 1 to 4 examples

Testing

Examples follow existing AWS CLI documentation format and provide realistic use cases for essential Macie2 security workflows including service setup, finding analysis, and data classification.

- Add enable-macie example showing basic and custom configuration
- Add get-findings example showing finding retrieval and filtering
- Add create-classification-job example for one-time and scheduled jobs
- Improves documentation coverage for Amazon Macie2 security service
@elysahall elysahall self-assigned this Oct 13, 2025
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Oct 13, 2025
@sushilk123
Copy link
Author

Hi, Could someone please review the PR?
@elysahall

Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sushilk123, I only have a few requested changes. After you update your examples, commit and push to this PR. Then we should be good for maintainer review.

@@ -0,0 +1,52 @@
**To create a classification job**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To create a classification job**
**Example 1: To create a classification job**

--job-type ONE_TIME \
--name "ExampleClassificationJob" \
--description "Analyze sensitive data in demo bucket" \
--s3-job-definition '{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter value either needs to be collapsed onto the same line, or each line also needs a line continuation mark.

"jobId": "42a1c188d7f838f9f0c1234567890"
}

**To create a scheduled classification job**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To create a scheduled classification job**
**Example 2: To create a scheduled classification job**

--job-type SCHEDULED \
--name "WeeklyClassificationJob" \
--description "Weekly scan for sensitive data" \
--schedule-frequency '{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This parameter value either needs to be collapsed onto the same line, or each line also needs a line continuation mark.

"dayOfWeek": "SUNDAY"
}
}' \
--s3-job-definition '{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This parameter value either needs to be collapsed onto the same line, or each line also needs a line continuation mark.

"type": "SensitiveData:S3Object/Personal"
}
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

@@ -0,0 +1,25 @@
**To enable Amazon Macie**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To enable Amazon Macie**
**Example 1: To enable Amazon Macie**

"status": "ENABLED"
}

**To enable Amazon Macie with custom configuration**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To enable Amazon Macie with custom configuration**
**Example 2: To enable Amazon Macie with custom configuration**

@@ -0,0 +1,88 @@
**To retrieve Amazon Macie findings**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To retrieve Amazon Macie findings**
**Example 1: To retrieve Amazon Macie findings**

]
}

**To retrieve findings with specific criteria**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To retrieve findings with specific criteria**
**Example 2: To retrieve findings with specific criteria**

@elysahall elysahall assigned sushilk123 and unassigned elysahall Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants