Skip to content

Commit 47562a7

Browse files
committed
actually, add back Unix Makefiles
1 parent f1743e2 commit 47562a7

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,10 @@ jobs:
151151
- name: Set up MSYS2
152152
uses: msys2/setup-msys2@v2
153153
with:
154-
msystem: MSYS
154+
msystem: MINGW64
155155
install: >-
156-
cmake
157-
make
158-
gcc
156+
mingw-w64-x86_64-cmake
157+
mingw-w64-x86_64-gcc
159158
- name: Setup build environment
160159
uses: ./.github/actions/setup-build
161160
- name: Build and Test ${{ env.PACKAGE_NAME }}

build-support/src/main/kotlin/aws/sdk/kotlin/gradle/crt/CMakeTasks.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private fun Project.registerCmakeConfigureTask(
126126
// The default CMake generator on Windows is "NMake Makefiles", requiring nmake.exe which is not installed by default on many hosts.
127127
// We use msys2/GCC to build, so configure "MSYS Makefiles" instead
128128
if (HostManager.hostIsMingw && knTarget.konanTarget.family == Family.MINGW) {
129-
// args.addAll(listOf("-G", "Unix Makefiles"))
129+
args.addAll(listOf("-G", "Unix Makefiles"))
130130
}
131131

132132
// FIXME? Compiling s2n-tls on GitHub Actions Ubuntu image (without Docker / cross-compilation) has errors like:

0 commit comments

Comments
 (0)