Skip to content

Commit 82cf075

Browse files
committed
cleaning up debug code; adding misc comments
1 parent 09fe7f9 commit 82cf075

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CMakeLists.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,6 @@ function(bundle_static_library name deps)
164164
)
165165

166166
elseif (CMAKE_C_COMPILER_ID MATCHES "^MSVC$")
167-
message(STATUS "Dumping all cmake variables:")
168-
get_cmake_property(_variableNames VARIABLES)
169-
list (SORT _variableNames)
170-
foreach (_variableName ${_variableNames})
171-
message(STATUS "${_variableName}=${${_variableName}}")
172-
endforeach()
173-
174167
foreach(tgt IN LISTS deps)
175168
list(APPEND static_libs_full_names $<TARGET_FILE:${tgt}>)
176169
endforeach()

build-support/src/main/kotlin/aws/sdk/kotlin/gradle/crt/CMakeTasks.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,20 @@ private fun Project.registerCmakeInstallTask(
209209
}
210210
}
211211

212+
/**
213+
* Konan targets for which a container will be used execute CMake tasks. Targets that do not appear in this list or are
214+
* disabled by `aws.sdk.kotlin.crt.disableCrossCompile` will be compiled without using a container (i.e., in the same
215+
* shell executing Gradle).
216+
*/
212217
private val containerCompileTargets = setOf(
213218
KonanTarget.LINUX_X64,
214219
KonanTarget.LINUX_ARM64,
215220
KonanTarget.MINGW_X64,
216221
)
217222

223+
/**
224+
* Konan targets which require explicitly running CMake inside of Bash
225+
*/
218226
private val requiresExplicitBash = setOf(
219227
KonanTarget.MINGW_X64,
220228
)

0 commit comments

Comments
 (0)