Skip to content

Commit 8882c38

Browse files
committed
Clarify FIXME message
1 parent 5624824 commit 8882c38

File tree

1 file changed

+1
-2
lines changed
  • build-support/src/main/kotlin/aws/sdk/kotlin/gradle/crt

1 file changed

+1
-2
lines changed

build-support/src/main/kotlin/aws/sdk/kotlin/gradle/crt/CMakeTasks.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,11 @@ private fun Project.registerCmakeConfigureTask(
121121
}
122122
}
123123

124-
// FIXME Recent upgrade to GitHub Actions Ubuntu image / s2n-tls causes compilation errors like:
124+
// FIXME? Compiling s2n-tls on GitHub Actions Ubuntu image (without Docker / cross-compilation) has errors like:
125125
// In function ‘s2n_hash_algorithms_init’
126126
// error: implicit declaration of function ‘EVP_MD_free’;
127127
// See https://github.com/aws/s2n-tls/blob/529b01a8363962a4e3809c9d9ee34fdd098fb0ba/tests/features/S2N_LIBCRYPTO_SUPPORTS_PROVIDERS.c#L29
128128
// and https://github.com/aws/s2n-tls/blob/529b01a8363962a4e3809c9d9ee34fdd098fb0ba/crypto/s2n_hash.c#L85
129-
// args.add("-DS2N_LIBCRYPTO_SUPPORTS_PROVIDERS=FALSE")
130129

131130
// executed from root build dir which is where CMakeLists.txt is
132131
// We _could_ use the undocumented -H flag but that will be harder to make work inside docker

0 commit comments

Comments
 (0)