Skip to content

Commit 987ac0f

Browse files
ajewellamzShubham Chaturvedi
andauthored
chore(go): test with go 1.23 (#1737)
Co-authored-by: Shubham Chaturvedi <[email protected]>
1 parent 1413b88 commit 987ac0f

File tree

6 files changed

+29
-25
lines changed

6 files changed

+29
-25
lines changed

.github/actions/install_smithy_dafny_codegen_dependencies/action.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,13 @@ runs:
1515
java-version: "17"
1616

1717
- name: Install smithy-dafny-codegen dependencies locally
18-
shell: bash
19-
run: |
20-
make -C smithy-dafny mvn_local_deploy_polymorph_dependencies
18+
uses: nick-fields/retry@v3
19+
with:
20+
timeout_minutes: 60
21+
retry_wait_seconds: 30
22+
max_attempts: 3
23+
shell: bash
24+
command: make -C smithy-dafny mvn_local_deploy_polymorph_dependencies
2125

2226
- name: Setup Python, black, and docformatter for code formatting
2327
uses: actions/setup-python@v6
@@ -33,15 +37,19 @@ runs:
3337
- name: Install Go
3438
uses: actions/setup-go@v6
3539
with:
36-
go-version: "1.24"
40+
go-version: "1.23"
3741

3842
- name: Install Go imports
3943
shell: bash
4044
run: |
41-
go install golang.org/x/tools/cmd/goimports@latest
45+
go install golang.org/x/tools/cmd/goimports@v0.36.0
4246
4347
# Without this the if-dafny-at-least command includes "Downloading ..." output
4448
- name: Arbitrary makefile target to force downloading Gradle
45-
shell: bash
46-
run: |
47-
make -C StandardLibrary setup_net
49+
uses: nick-fields/retry@v3
50+
with:
51+
timeout_minutes: 60
52+
retry_wait_seconds: 30
53+
max_attempts: 3
54+
shell: bash
55+
command: make -C StandardLibrary setup_net

.github/actions/polymorph_codegen/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ runs:
9797
run: |
9898
make polymorph_go
9999
100-
- name: Check regenerated code against commited code
100+
- name: Check regenerated code against committed code
101101
# Composite action inputs seem to not actually support booleans properly for some reason
102102
if: inputs.diff-generated-code == 'true'
103103
working-directory: ./${{ inputs.library }}

.github/workflows/go-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ jobs:
5656
- name: Install Go
5757
uses: actions/setup-go@v6
5858
with:
59-
go-version: "1.24"
59+
go-version: "1.23"
6060

6161
- name: Install Go imports
6262
run: |
63-
go install golang.org/x/tools/cmd/goimports@latest
63+
go install golang.org/x/tools/cmd/goimports@v0.36.0
6464
6565
- name: Install Smithy-Dafny codegen dependencies
6666
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies

.github/workflows/library_codegen.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
# in this workflow.
3030
# The workflow installs black and docformatter and runs them on generated code.
3131
python-version: [3.11]
32-
go-version: [1.24]
32+
go-version: [1.23]
3333
os: [ubuntu-22.04]
3434
runs-on: ${{ matrix.os }}
3535
defaults:
@@ -70,7 +70,7 @@ jobs:
7070
- name: Install Go imports
7171
shell: bash
7272
run: |
73-
go install golang.org/x/tools/cmd/goimports@latest
73+
go install golang.org/x/tools/cmd/goimports@v0.36.0
7474
7575
# even though we just installed dotnet 6, maybe dotnet 8 is out there somewhere
7676
- name: Create temporary global.json

.github/workflows/library_go_tests.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
AwsCryptographicMaterialProviders,
2929
TestVectorsAwsCryptographicMaterialProviders,
3030
]
31-
go-version: ["1.24", "1.25"]
31+
go-version: ["1.23", "1.24", "1.25"]
3232
os: [
3333
# TODO fix Dafny-generated tests on Windows;
3434
# the sys.path workaround for generated Dafny doesn't work on Windows.
@@ -68,18 +68,14 @@ jobs:
6868
with:
6969
dafny-version: ${{ inputs.dafny }}
7070

71+
- name: Install Smithy-Dafny codegen dependencies
72+
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies
73+
7174
- name: Install Go
7275
uses: actions/setup-go@v6
7376
with:
7477
go-version: ${{ matrix.go-version }}
7578

76-
- name: Install Go imports
77-
run: |
78-
go install golang.org/x/tools/cmd/goimports@latest
79-
80-
- name: Install Smithy-Dafny codegen dependencies
81-
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies
82-
8379
- name: Build ${{ matrix.library }} implementation
8480
working-directory: ./${{ matrix.library }}
8581
run: |

.github/workflows/library_interop_tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ jobs:
112112
- name: Setup Go
113113
uses: actions/setup-go@v6
114114
with:
115-
go-version: "1.24"
115+
go-version: "1.23"
116116

117117
- name: Install Go imports
118118
run: |
119-
go install golang.org/x/tools/cmd/goimports@latest
119+
go install golang.org/x/tools/cmd/goimports@v0.36.0
120120
121121
- name: Setup NASM for Windows in Rust (aws-lc-sys)
122122
if: matrix.language == 'rust' && matrix.os == 'windows-latest'
@@ -314,11 +314,11 @@ jobs:
314314
- name: Setup Go
315315
uses: actions/setup-go@v6
316316
with:
317-
go-version: "1.24"
317+
go-version: "1.23"
318318

319319
- name: Install Go imports
320320
run: |
321-
go install golang.org/x/tools/cmd/goimports@latest
321+
go install golang.org/x/tools/cmd/goimports@v0.36.0
322322
323323
- name: Setup NASM for Windows in Rust (aws-lc-sys)
324324
if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest'

0 commit comments

Comments
 (0)