Skip to content

Commit e0caa14

Browse files
fix(Python): Handle docformatter exit codes (#588)
1 parent 9dd74be commit e0caa14

File tree

1 file changed

+7
-1
lines changed
  • codegen/smithy-dafny-codegen-modules/smithy-python/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen

1 file changed

+7
-1
lines changed

codegen/smithy-dafny-codegen-modules/smithy-python/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/DirectedPythonCodegen.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,13 @@ private void formatDocstrings(FileManifest fileManifest) {
361361
return;
362362
}
363363
LOGGER.info("Running docformatter on generated code");
364-
CodegenUtils.runCommand("python3 -m docformatter --recursive .", fileManifest.getBaseDir());
364+
// docformatter exit codes:
365+
// 0: docformatter did not make changes
366+
// 1: docformatter made changes
367+
// 2: Invalid docformatter usage (incorrect arguments, etc.)
368+
// If docformatter returns exit codes 0 or 1, then exit 0 to CodegenUtils. Otherwise, exit 1.
369+
CodegenUtils.runCommand(
370+
"python3 -m docformatter --recursive --in-place .; [ $? -eq 0 ] || [ $? -eq 1 ] || exit 1", fileManifest.getBaseDir());
365371
}
366372

367373
private void runMypy(FileManifest fileManifest) {

0 commit comments

Comments
 (0)