Skip to content

Commit 08b9932

Browse files
author
Lucas McDonald
committed
m
1 parent 084f4d3 commit 08b9932

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

DynamoDbEncryption/runtimes/python/test/integ/encrypted/test_client.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,10 +476,10 @@ def test_WHEN_execute_statement_for_plaintext_table_THEN_passes(
476476
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
477477

478478
@pytest.fixture
479-
def execute_transaction_request(execute_uses_encrypted_table):
479+
def execute_transaction_request(execute_uses_encrypted_table, test_item):
480480
if execute_uses_encrypted_table:
481-
return basic_execute_transaction_request_encrypted_table()
482-
return basic_execute_transaction_request_plaintext_table()
481+
return basic_execute_transaction_request_encrypted_table(test_item)
482+
return basic_execute_transaction_request_plaintext_table(test_item)
483483

484484

485485
def test_WHEN_execute_transaction_for_encrypted_table_THEN_raises_DynamoDbEncryptionTransformsException(
@@ -491,7 +491,7 @@ def test_WHEN_execute_transaction_for_encrypted_table_THEN_raises_DynamoDbEncryp
491491
"""Test that execute_transaction raises DynamoDbEncryptionTransformsException."""
492492
if not encrypted:
493493
pytest.skip("Skipping negative test for plaintext client")
494-
494+
495495
if execute_uses_encrypted_table:
496496
# Given: Encrypted client and execute_transaction request on encrypted table
497497
# Then: DynamoDbEncryptionTransformsException is raised
@@ -505,10 +505,14 @@ def test_WHEN_execute_transaction_for_plaintext_table_THEN_passes(
505505
client,
506506
execute_transaction_request,
507507
execute_uses_encrypted_table,
508+
put_item_request,
508509
):
509510
if execute_uses_encrypted_table:
510511
pytest.skip("Skipping test for encrypted table; this test is only for plaintext tables")
511512

513+
put_response = client.put_item(**put_item_request)
514+
assert put_response["ResponseMetadata"]["HTTPStatusCode"] == 200
515+
512516
# Given: Client calls execute_transaction on plaintext table
513517
# When: Calling execute_transaction
514518
response = client.execute_transaction(**execute_transaction_request)

DynamoDbEncryption/runtimes/python/test/requests.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,30 +92,30 @@ def basic_execute_statement_request_plaintext_table():
9292
return {"Statement": "SELECT * FROM " + INTEG_TEST_DEFAULT_DYNAMODB_TABLE_NAME_PLAINTEXT}
9393

9494

95-
def basic_execute_transaction_request_encrypted_table():
95+
def basic_execute_transaction_request_encrypted_table(item):
9696
"""Base structure for execute_transaction requests for an encrypted table."""
9797
return {
9898
"TransactStatements": [
9999
{
100100
"Statement": f"SELECT * FROM {INTEG_TEST_DEFAULT_DYNAMODB_TABLE_NAME} WHERE partition_key=? AND sort_key=?",
101101
"Parameters": [
102-
{"S": "fake_nonexistent_partition_key"},
103-
{"S": "fake_nonexistent_sort_key"}
102+
item["partition_key"],
103+
item["sort_key"]
104104
]
105105
}
106106
]
107107
}
108108

109109

110-
def basic_execute_transaction_request_plaintext_table():
110+
def basic_execute_transaction_request_plaintext_table(item):
111111
"""Base structure for execute_transaction requests for a plaintext table."""
112112
return {
113113
"TransactStatements": [
114114
{
115115
"Statement": f"SELECT * FROM {INTEG_TEST_DEFAULT_DYNAMODB_TABLE_NAME_PLAINTEXT} WHERE partition_key=? AND sort_key=?",
116116
"Parameters": [
117-
{"S": "fake_nonexistent_partition_key"},
118-
{"S": "fake_nonexistent_sort_key"}
117+
item["partition_key"],
118+
item["sort_key"]
119119
]
120120
}
121121
]

0 commit comments

Comments
 (0)