sync

Author: Lucas McDonald

DynamoDbEncryption/runtimes/python/src/aws_dbesdk_dynamodb/encrypted/client.py

@@ -72,12 +72,15 @@ class EncryptedClient(EncryptedBotoInterface):
     Any calls to ``update_item`` can only update unsigned attributes. If an attribute to be updated is marked as signed,
     this operation will raise a ``DynamoDbEncryptionTransformsException``.
 
-    The following operations are not supported and will raise DynamoDbEncryptionTransformsException:
+    The following operations are not supported for encrypted tables:
 
         * ``execute_statement``
         * ``execute_transaction``
         * ``batch_execute_statement``
 
+    Calling these operations for encrypted tables will raise a ``DynamoDbEncryptionTransformsException``.
+    This client can still be used to call these operations on plaintext tables.
+
     Any other operations on this class will defer to the underlying boto3 DynamoDB client's implementation.
 
     ``EncryptedClient`` can also return an ``EncryptedPaginator`` for transparent decryption of paginated results.

DynamoDbEncryption/runtimes/python/test/integ/encrypted/test_client.py

@@ -420,7 +420,6 @@ def test_WHEN_update_item_with_signed_attribute_THEN_raises_DynamoDbEncryptionTr
     update_item_request_signed_attribute,
     encrypted,
 ):
-    """Test that update_item raises DynamoDbEncryptionTransformsException."""
     if not encrypted:
         pytest.skip("Skipping negative test for plaintext client")
 
@@ -431,6 +430,11 @@ def test_WHEN_update_item_with_signed_attribute_THEN_raises_DynamoDbEncryptionTr
         client.update_item(**update_item_request_signed_attribute)
 
 
+# Create a matrix of tests for each value in param,
+# with a user-friendly string for test output:
+# execute_uses_encrypted_table = True -> "encrypted_table"
+# execute_uses_encrypted_table = False -> "plaintext_table"
+# This indicates whether an execute_(statement,transaction,etc.) operation should be on an encrypted table
 @pytest.fixture(params=[True, False], ids=["encrypted_table", "plaintext_table"])
 def execute_uses_encrypted_table(request):
     return request.param
@@ -449,7 +453,6 @@ def test_WHEN_execute_statement_for_encrypted_table_THEN_raises_DynamoDbEncrypti
     encrypted,
     execute_uses_encrypted_table,
 ):
-    """Test that execute_statement raises DynamoDbEncryptionTransformsException."""
     if not encrypted:
         pytest.skip("Skipping negative test for plaintext client")
 
@@ -491,7 +494,6 @@ def test_WHEN_execute_transaction_for_encrypted_table_THEN_raises_DynamoDbEncryp
     encrypted,
     execute_uses_encrypted_table,
 ):
-    """Test that execute_transaction raises DynamoDbEncryptionTransformsException."""
     if not encrypted:
         pytest.skip("Skipping negative test for plaintext client")
 
@@ -537,7 +539,6 @@ def test_WHEN_batch_execute_statement_for_encrypted_table_THEN_raises_DynamoDbEn
     encrypted,
     execute_uses_encrypted_table,
 ):
-    """Test that batch_execute_statement raises DynamoDbEncryptionTransformsException."""
     if not encrypted:
         pytest.skip("Skipping negative test for plaintext client")