Trim analysis warning IL2070 caused by SerializationOptions

[runenur]

Describe the bug

When enabling AOT, a trim analysis warning is logged even though I use the correct JsonSerializerContext overload.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expect no trim analysis warnings.

Current Behavior

I get the following warning:

Trim analysis warning IL2070: System.Text.Json.Serialization.Converters.EnumConverterFactory.Create(Type,EnumConverterOptions,JsonNamingPolicy,JsonSerializerOptions): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Type.MakeGenericType(Type[])'. The parameter 'enumType' of method 'System.Text.Json.Serialization.Converters.EnumConverterFactory.
Create(Type,EnumConverterOptions,JsonNamingPolicy,JsonSerializerOptions)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

Reproduction Steps

All you need is a call to AddAWSMessageBus with a JsonSerializerContext and an empty callback. I set the project property TrimmerSingleWarn to false in order to get the exact warning, and not a single generic one.

Possible Solution

After some digging, I found that SerializationOptions creates an instance of JsonStringEnumConverter, which causes the warning. I tried with a custom build of AWS.Messaging that did not create this instance, and the warning went away.

When you provide a JsonSerializerContext, this instance will never be used. But the warning does not seem to be depressed anywhere.

Additional Information/Context

No response

AWS.Messaging (or related) package versions

AWS.Messaging.Lambda 1.0.1

Targeted .NET Platform

.NET 8

Operating System and version

Windows 11

[GarrettBeatty]

Hi can you share the exact code that reproduces this issue? I tried with something like

using System.Text.Json;
using System.Text.Json.Serialization;
using AWS.Messaging;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;

namespace MessagingLocalAOTTest;

public record ProductDTO(string ID, string Name, string Description);

[JsonSerializable(typeof(ProductDTO))]
[JsonSourceGenerationOptions(UseStringEnumConverter = true)]
public partial class MessageFunctionJsonSerializerContext : JsonSerializerContext
{
}

class Program
{
    static void Main(string[] args)
    {
        var builder = new HostApplicationBuilder();

        var queueUrl = "<queue-url>";
        builder.Services.AddAWSMessageBus(MessageFunctionJsonSerializerContext.Default, builder =>
        {
           
        });

        var app = builder.Build();

        var task = app.RunAsync();
    }
}

but not seeing any trim warnings

dotnet publish -c Release -r win-x64 /p:PublishAot=true /p:PublishTrimmed=true
Restore complete (1.4s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  ConsoleApp1 succeeded (5.3s) → ConsoleApp1\bin\Release\net8.0\win-x64\publish\

Build succeeded in 7.2s

[runenur]

I tried your exact code, and I get the following:

dotnet publish -c Release -r win-x64 /p:PublishAot=true /p:PublishTrimmed=true
  Determining projects to restore...
  Restored C:\Dev\aws-repro\Repro.csproj (in 315 ms).
  Repro -> C:\Dev\aws-repro\bin\Release\net8.0\win-x64\Repro.dll
  Generating native code
ILC : Trim analysis warning IL2070: System.Text.Json.Serialization.Converters.EnumConverterFactory.Create(Type,EnumConverterOptions,JsonNamingPolicy,JsonSerializerOptions): 'this' argument does not satisfy 'D
ynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Type.MakeGenericType(Type[])'. The parameter 'enumType' of method 'System.Text.Json.Serialization.Converters.EnumConverterFacto
ry.Create(Type,EnumConverterOptions,JsonNamingPolicy,JsonSerializerOptions)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target lo
cation it is assigned to. [C:\Dev\aws-repro\Repro.csproj]
  Repro -> C:\Dev\aws-repro\bin\Release\net8.0\win-x64\publish\

I am currently using .NET v8.0.414.

[runenur]

I used the following code:

aws-dotnet-messaging-294.zip

[GarrettBeatty]

i was able to reproduce the issue with your code. seems for some reason when i was building it, it wasnt consistent.

otnet publish Repro.csproj -c Release -r win-x64 /p:PublishAot=true /p:PublishTrimmed=true /p:TrimmerSingleWarn=false
  Determining projects to restore...
  All projects are up-to-date for restore.
  Repro -> C:\Users\gcbeatty\Downloads\aws-dotnet-messaging-294\bin\Release\net8.0\win-x64\Repro.dll
  Repro -> C:\Users\gcbeatty\Downloads\aws-dotnet-messaging-294\bin\Release\net8.0\win-x64\publish\
 aws-dotnet-messaging-294  dotnet publish Repro.csproj -c Release -r win-x64 /p:PublishAot=true /p:PublishTrimmed=true /p:TrimmerSingleWarn=false
  Determining projects to restore...
  Restored C:\Users\gcbeatty\Downloads\aws-dotnet-messaging-294\Repro.csproj (in 798 ms).
  Repro -> C:\Users\gcbeatty\Downloads\aws-dotnet-messaging-294\bin\Release\net8.0\win-x64\Repro.dll
  Generating native code
ILC : Trim analysis warning IL2070: System.Text.Json.Serialization.Converters.EnumConverterFactory.Create(Type,EnumConverterOptions,JsonNamingPolicy,JsonSerializerOptions): 'this' argument does not satisfy 'DynamicallyA
ccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Type.MakeGenericType(Type[])'. The parameter 'enumType' of method 'System.Text.Json.Serialization.Converters.EnumConverterFactory.Create(Type,EnumCon 
verterOptions,JsonNamingPolicy,JsonSerializerOptions)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [C:\Use 
rs\gcbeatty\Downloads\aws-dotnet-messaging-294\Repro.csproj]

[GarrettBeatty]

I think i was able to narrow it down why i couldnt reproduce it the first time.

in your test code i see you are using

    <PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.9" />

With 9.0.9 im able to consistently reproduce the issue.

i just tried with using

    <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.1" />

instead and im not seeing that trim warning. In our AWS.Messaging.csproj we are using all 8.0.* versions of these packages. im thinking there may be some conflict or some other issue with using a 9.0 version. Can you try using

    <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.1" />

and see if you are also seeing this same behavior? In the meantime ill talk with the team to see if we need to make a fix anyway on this