Skip to content

chore: Add go to smithy dependencies #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajewellamz merged 5 commits into from
Sep 8, 2025
Merged

chore: Add go to smithy dependencies #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e53750
chore: bump mpl to allow nightly build
ajewellamz Sep 5, 2025
bf1770b
chore: Add go to smithy dependencies
ajewellamz Sep 8, 2025
18774a3
Merge branch 'mainline' into ajewell/add-go-to-setup
ajewellamz Sep 8, 2025
4a022db
dont double install go
ajewellamz Sep 8, 2025
725e6cb
Merge branch 'ajewell/add-go-to-setup' of github.com:aws/aws-encrypti…
ajewellamz Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/actions/install_smithy_dafny_codegen_dependencies/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ runs:
python -m pip install --upgrade black
python -m pip install --upgrade docformatter

- name: Install Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
shell: bash
run: |
go install golang.org/x/tools/cmd/goimports@latest

# Without this the if-dafny-at-least command includes "Downloading ..." output
- name: Arbitrary makefile target to force downloading Gradle
shell: bash
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/dafny_interop_library_go_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ jobs:
with:
go-version: ${{ matrix.go-version }}

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Compile MPL with Dafny ${{inputs.mpl-dafny}}
shell: bash
working-directory: mpl/TestVectorsAwsCryptographicMaterialProviders
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/go-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,6 @@ jobs:
with:
dafny-version: ${{ needs.get-dafny-version.outputs.version }}

- name: Install Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Install Smithy-Dafny codegen dependencies
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/library_codegen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ jobs:
with:
go-version: ${{ matrix.go-version }}

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Install Smithy-Dafny codegen dependencies
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies

Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/library_go_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ jobs:
with:
go-version: ${{ matrix.go-version }}

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Compile ${{ matrix.library }} implementation
shell: bash
working-directory: ${{ matrix.library }}
Expand Down
18 changes: 0 additions & 18 deletions .github/workflows/library_interop_keyring_test_vectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,6 @@ jobs:
with:
components: rustfmt

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Setup NASM for Windows in Rust (aws-lc-sys)
if: matrix.language == 'rust' && matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1
Expand Down Expand Up @@ -449,15 +440,6 @@ jobs:
with:
components: rustfmt

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Setup NASM for Windows in Rust (aws-lc-sys)
if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1
Expand Down
27 changes: 0 additions & 27 deletions .github/workflows/library_interop_mkp_test_vectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,6 @@ jobs:
with:
components: rustfmt

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Setup NASM for Windows in Rust (aws-lc-sys)
if: matrix.language == 'rust' && matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1
Expand Down Expand Up @@ -304,15 +295,6 @@ jobs:
with:
components: rustfmt

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Setup NASM for Windows in Rust (aws-lc-sys)
if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1
Expand Down Expand Up @@ -737,15 +719,6 @@ jobs:
with:
components: rustfmt

- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: "1.23"

- name: Install Go imports
run: |
go install golang.org/x/tools/cmd/goimports@latest

- name: Setup NASM for Windows in Rust (aws-lc-sys)
if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/library_rust_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ jobs:
if: matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1

# Go is needed for aws-lc-FIPS
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: ">=1.18"

- name: Install Smithy-Dafny codegen dependencies
uses: ./.github/actions/install_smithy_dafny_codegen_dependencies

Expand Down
Loading