chore: add managed policy to cfn template #847
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamChaturvedi7
previously approved these changes
Jan 15, 2026
lucasmcdonald3
previously approved these changes
Jan 15, 2026
cfn/CI.yaml
Outdated
| Type: "AWS::IAM::Role" | ||
| Properties: | ||
| RoleName: !Sub "GitHub-CI-${ProjectName}-Role-${AWS::Region}" | ||
| MaxSessionDuration: 3600 |
Member
There was a problem hiding this comment.
The CI is not passing because this got reduced to 3600 which might had been changed with management console and cfn is showing old MaxSessionDuration
Suggested change
| MaxSessionDuration: 7200 |
rishav-karanjit
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
and address drift
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.