Fix MSBuild property evaluation (#355)

martincostello · web-flow · commit 2c711df14779 · 2024-12-19T10:20:03.000-08:00
Fix MSBuild parameters specified in `aws-lambda-tools-defaults.json` not being used with `Utilities.LookPublishAotFlag()`. Resolves #351.
diff --git a/src/Amazon.Lambda.Tools/Commands/PackageCommand.cs b/src/Amazon.Lambda.Tools/Commands/PackageCommand.cs
@@ -220,7 +220,7 @@ protected override async Task<bool> PerformActionAsync()
                     }
                 }
 
-                bool isNativeAot = Utilities.LookPublishAotFlag(projectLocation, this.MSBuildParameters);
+                bool isNativeAot = Utilities.LookPublishAotFlag(projectLocation, msbuildParameters);
 
                 var architecture = this.GetStringValueOrDefault(this.Architecture, LambdaDefinedCommandOptions.ARGUMENT_FUNCTION_ARCHITECTURE, false);
                 var disableVersionCheck = this.GetBoolValueOrDefault(this.DisableVersionCheck, LambdaDefinedCommandOptions.ARGUMENT_DISABLE_VERSION_CHECK, false).GetValueOrDefault();

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ protected override async Task<bool> PerformActionAsync()`
`220`	`220`	`}`
`221`	`221`	`}`
`222`	`222`
`223`		`- bool isNativeAot = Utilities.LookPublishAotFlag(projectLocation, this.MSBuildParameters);`
	`223`	`+ bool isNativeAot = Utilities.LookPublishAotFlag(projectLocation, msbuildParameters);`
`224`	`224`
`225`	`225`	`var architecture = this.GetStringValueOrDefault(this.Architecture, LambdaDefinedCommandOptions.ARGUMENT_FUNCTION_ARCHITECTURE, false);`
`226`	`226`	`var disableVersionCheck = this.GetBoolValueOrDefault(this.DisableVersionCheck, LambdaDefinedCommandOptions.ARGUMENT_DISABLE_VERSION_CHECK, false).GetValueOrDefault();`