Skip to content

Commit 71d4a6a

Browse files
authored
Fixed issue detecting if log parameters have changed since previous deployment. (#343)
1 parent 1b144c3 commit 71d4a6a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
### Amazon.Lambda.Tools (5.11.1)
44
* Fixed an issue where primitive values in payload for InvokeFunctionCommand were not working.
5+
* Fixed issue detecting if log parameters have changed since previous deployment.
56

67
## Release 2024-10-09
78

aws-extensions-for-dotnet-cli.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Amazon.ECS.Tools.Test", "te
2525
EndProject
2626
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{90827CB6-7488-4B53-904B-F045BCC754F3}"
2727
ProjectSection(SolutionItems) = preProject
28+
CHANGELOG.md = CHANGELOG.md
2829
README.md = README.md
29-
RELEASE.CHANGELOG.md = RELEASE.CHANGELOG.md
3030
EndProjectSection
3131
EndProject
3232
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Amazon.Lambda.Tools", "src\Amazon.Lambda.Tools\Amazon.Lambda.Tools.csproj", "{26CEBD54-FC5B-4437-A009-6643EE849413}"

src/Amazon.Lambda.Tools/Commands/UpdateFunctionConfigCommand.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ private UpdateFunctionConfigurationRequest CreateConfigurationRequestIfDifferent
651651
request.LoggingConfig = new LoggingConfig();
652652
}
653653

654-
if (!string.Equals(request.LoggingConfig.LogFormat, existingConfiguration.LoggingConfig?.LogFormat, StringComparison.Ordinal))
654+
if (!string.Equals(logFormat, existingConfiguration.LoggingConfig?.LogFormat, StringComparison.Ordinal))
655655
{
656656
request.LoggingConfig.LogFormat = logFormat;
657657
different = true;
@@ -666,7 +666,7 @@ private UpdateFunctionConfigurationRequest CreateConfigurationRequestIfDifferent
666666
request.LoggingConfig = new LoggingConfig();
667667
}
668668

669-
if (!string.Equals(request.LoggingConfig.ApplicationLogLevel, existingConfiguration.LoggingConfig?.ApplicationLogLevel, StringComparison.Ordinal))
669+
if (!string.Equals(logApplicationLevel, existingConfiguration.LoggingConfig?.ApplicationLogLevel, StringComparison.Ordinal))
670670
{
671671
request.LoggingConfig.ApplicationLogLevel = logApplicationLevel;
672672
different = true;
@@ -681,7 +681,7 @@ private UpdateFunctionConfigurationRequest CreateConfigurationRequestIfDifferent
681681
request.LoggingConfig = new LoggingConfig();
682682
}
683683

684-
if (!string.Equals(request.LoggingConfig.SystemLogLevel, existingConfiguration.LoggingConfig?.SystemLogLevel, StringComparison.Ordinal))
684+
if (!string.Equals(logSystemLevel, existingConfiguration.LoggingConfig?.SystemLogLevel, StringComparison.Ordinal))
685685
{
686686
request.LoggingConfig.SystemLogLevel = logSystemLevel;
687687
different = true;
@@ -696,7 +696,7 @@ private UpdateFunctionConfigurationRequest CreateConfigurationRequestIfDifferent
696696
request.LoggingConfig = new LoggingConfig();
697697
}
698698

699-
if (!string.Equals(request.LoggingConfig.LogGroup, existingConfiguration.LoggingConfig?.LogGroup, StringComparison.Ordinal))
699+
if (!string.Equals(logGroup, existingConfiguration.LoggingConfig?.LogGroup, StringComparison.Ordinal))
700700
{
701701
request.LoggingConfig.LogGroup = logGroup;
702702
different = true;

0 commit comments

Comments
 (0)