Skip to content

Commit 8a5608b

Browse files
committed
Address PR comments
1 parent cac10d2 commit 8a5608b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/Amazon.Common.DotNetCli.Tools/Utilities.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ public static string DeterminePublishLocation(string workingDirectory, string pr
211211
/// Looks up specified properties from a project.
212212
/// </summary>
213213
/// <param name="projectLocation">The location of the project file.</param>
214-
/// <param name="msBuildParameters">Additonal MSBuild paramteres passed by the user from the commandline</param>
214+
/// <param name="msBuildParameters">Additional MSBuild parameters passed by the user from the commandline</param>
215215
/// <param name="propertyNames">The names of the properties to look up.</param>
216216
/// <returns>A dictionary of property names and their values.</returns>
217217
public static Dictionary<string, string> LookupProjectProperties(string projectLocation, string msBuildParameters, params string[] propertyNames)

test/Amazon.Common.DotNetCli.Tools.Test/UtilitiesTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ public void TestHasExplicitSelfContainedFlag(string projectLocation, string msBu
105105
[InlineData("TargetFramework", "", "net6.0")]
106106
[InlineData("TargetFramework", "/p:NonExistence=net20.0", "net6.0")]
107107
[InlineData("TargetFramework", "/p:TargetFramework=net20.0", "net20.0")]
108+
[InlineData("TargetFramework", "/p:TargetFramework=net20.0 /p:OutputType=FutureDevice", "net20.0")]
109+
[InlineData("OutputType", "/p:TargetFramework=net20.0 /p:OutputType=FutureDevice", "FutureDevice")]
108110
public void TestPropertyEvaluationWithMSBuildParameters(string property, string msbuildparameters, string expectedValue)
109111
{
110112
var projectLocation = "../../../../../testapps/TestFunction";

0 commit comments

Comments
 (0)