Skip to content

Directory.build.props heirarchy is not respectedΒ #211

@toddlang

Description

@toddlang

Describe the bug

When packaging a lambda using dotnet lambda package, if the target project does not include a <TargetFramework> node (because it is defined in a Directory.build.props at a higher location) the packaging tool fails saying it does not know what framework to use.

Missing required parameter: --framework

Expected Behavior

The tool will understand that MSBuild can walk directories searching for Directory.build.props files to define these values.

Current Behavior

The tool fails to walk the folder heirarchy to find the values necessary for the build.

Reproduction Steps

Create a csproj file for a lambda without <TargetFramework>.
In a directory higher (say, next to your sln file) define a 'Directory.build.props' file and add a node there.

This behaviour is all defined here:
https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2022

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

dotnet lambda tools 5.3.0

Targeted .NET Platform

.Net 6

Operating System and version

Windows 10

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions