Skip to content

Commit 63814d4

Browse files
committed
build: fix patching cherry picking issues
Signed-off-by: Matthew Fala <[email protected]>
1 parent 54b2ff3 commit 63814d4

File tree

3 files changed

+10
-19
lines changed

3 files changed

+10
-19
lines changed

AWS_FLB_CHERRY_PICKS

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ https://github.com/PettitWesley/fluent-bit.git mk_event_add_corruption-one-commi
4242
# Useful debug messages for input events
4343
# input chunk append message with input name context and number of records
4444
https://github.com/PettitWesley/fluent-bit.git chunk-append-context b671ed38e7ae87ab955083e2324ef1972298c5d7
45+
4546
# in_tail file name context for inotify events
4647
https://github.com/PettitWesley/fluent-bit.git tail-modify-debug-context-immutable-cherry-pick ab11d1d7438f5254d04eba8dfc2f10b78cc2244d
4748
https://github.com/PettitWesley/fluent-bit.git tail-modify-debug-context-immutable-cherry-pick 1f3bdeec49ac42b04b921303610ea0f53110ab2c
@@ -83,15 +84,6 @@ https://github.com/fluent/fluent-bit.git 1.9 81cdf7eced4e420043277237fba092157b1
8384
# upstream engine retry clean up fix https://github.com/fluent/fluent-bit/pull/6862
8485
https://github.com/fluent/fluent-bit.git 1.9 712e5fbe10bee44269d5dfed214c4e087ea1ec2a
8586

86-
# TCP input: user friendly message for skipping logs https://github.com/fluent/fluent-bit/pull/6061
87-
https://github.com/fluent/fluent-bit.git 1.9 c5d57ccf4f85af77e2a2bbb1121df95887e2962f
88-
89-
# ElasticSearch: fix buffer bulk over run https://github.com/fluent/fluent-bit/pull/5770
90-
https://github.com/fluent/fluent-bit.git 1.9 d3a0697c3c4a876250cc6c2c4ff44cd77908ea3c
91-
92-
# windows: fix time zone offset https://github.com/fluent/fluent-bit/pull/6368
93-
https://github.com/fluent/fluent-bit.git 1.9 cae9a8f9cb6eab7449f14d914f9ba1d8d4e93cf0
94-
9587
# quick fix for S3 key $INDEX bug https://github.com/aws/aws-for-fluent-bit/issues/653
9688
https://github.com/PettitWesley/fluent-bit.git index_s3_key_format_quick_fix 5e48218670681aef152aeedcf90a4593ac623470
9789

@@ -127,7 +119,7 @@ https://github.com/PettitWesley/fluent-bit.git filter-modify-fix-aws-distro 1a72
127119
# AWS core code self-review issue fixes
128120
# upstream version of this: https://github.com/fluent/fluent-bit/pull/7512/files
129121
# use calloc in all credential code to prevent freeing of garbage pointers
130-
https://github.com/PettitWesley/fluent-bit.git aws-distro-crypto-self-review eb48b79b34f91d36d28434390b976e882d553681
122+
https://github.com/PettitWesley/fluent-bit.git aws-distro-crypto-self-review eb48b79b34f91d36d28434390b976e882d553681
131123
# fix brittle XML parsing
132124
https://github.com/PettitWesley/fluent-bit.git aws-distro-crypto-self-review e6401ad3811b42dee0b7f92aba726cca4bee74ec
133125
# add pthread_mutex + trylock to protect cred providers
@@ -144,5 +136,3 @@ https://github.com/matthewfala/fluent-bit.git immutable-2.32.0-prometheus-sigv4
144136
# multiline: remove incorrect flush
145137
https://github.com/matthewfala/fluent-bit.git immutable-multiline-incorrect-flush 6431a4e584d52170dbe873d93ba532659921740a
146138
https://github.com/matthewfala/fluent-bit.git immutable-multiline-incorrect-flush 35f23875ca356ea30e9aac19854b810cf8ecad8f
147-
148-
# End of cherrypicks (end with a blank line)

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ all: release
1717
export DOCKER_BUILD_FLAGS=--no-cache
1818

1919
.PHONY: release
20-
release: build build-init
20+
release: build build-init linux-plugins
2121
docker system prune -f
2222
docker build $(DOCKER_BUILD_FLAGS) -t amazon/aws-for-fluent-bit:main-release -f ./scripts/dockerfiles/Dockerfile.main-release .
2323
docker tag amazon/aws-for-fluent-bit:main-release amazon/aws-for-fluent-bit:latest
@@ -28,7 +28,7 @@ release: build build-init
2828
debug: main-debug init-debug
2929

3030
.PHONY: build
31-
build: linux-plugins
31+
build:
3232
docker system prune -f
3333
docker build $(DOCKER_BUILD_FLAGS) -t amazon/aws-for-fluent-bit:build -f ./scripts/dockerfiles/Dockerfile.build .
3434

@@ -118,7 +118,7 @@ init-debug-s3: main-debug-base build-init
118118
docker build $(DOCKER_BUILD_FLAGS) -t amazon/aws-for-fluent-bit:init-debug-s3 -f ./scripts/dockerfiles/Dockerfile.init-debug-s3 .
119119

120120
.PHONY: main-debug-base
121-
main-debug-base: build
121+
main-debug-base: build linux-plugins
122122
docker build $(DOCKER_BUILD_FLAGS) -t amazon/aws-for-fluent-bit:main-debug-base -f ./scripts/dockerfiles/Dockerfile.main-debug-base .
123123

124124
.PHONY: validate-version-file-format

scripts/dockerfiles/Dockerfile.build

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,15 @@ COPY AWS_FLB_CHERRY_PICKS \
8888
RUN git config --global user.email "[email protected]" \
8989
&& git config --global user.name "FireLens Team"
9090

91-
RUN AWS_FLB_CHERRY_PICKS_COUNT=`cat /AWS_FLB_CHERRY_PICKS | sed '/^#/d' | sed '/^\s*$/d' | wc -l | awk '{ print $1 }'`; \
91+
RUN AWS_FLB_CHERRY_PICKS_COUNT=`awk '{print $0 }' /AWS_FLB_CHERRY_PICKS | sed '/^#/d' | sed '/^\s*$/d' | wc -l | awk '{ print $1 }'`; echo $AWS_FLB_CHERRY_PICKS_COUNT; \
9292
if [ $AWS_FLB_CHERRY_PICKS_COUNT -gt 0 ]; \
9393
then \
9494
cat /AWS_FLB_CHERRY_PICKS | sed '/^#/d' \
95-
| xargs -l bash -c 'git fetch $0 $1 && git cherry-pick $2'; \
95+
| xargs -l bash -c 'git fetch $0 $1 && git cherry-pick $2 || exit 255' && \
9696
\
97-
echo "Cherry Pick Patch Summary:"; \
97+
(echo "Cherry Pick Patch Summary:"; \
98+
echo -n "Base "; \
9899
git log --oneline \
99100
-$((AWS_FLB_CHERRY_PICKS_COUNT+1)) \
100-
| tac | awk '{ print "Commit",NR-1,"--",$0 }'; sleep 2; \
101+
| tac | awk '{ print "Commit",NR-1,"--",$0 }'; sleep 2;)\
101102
fi

0 commit comments

Comments
 (0)