Skip to content

Commit 69366b1

Browse files
committed
integ: validator image must support different platforms, linux vs windows, arm vs amd
Signed-off-by: Wesley Pettit <[email protected]>
1 parent 9fb760b commit 69366b1

File tree

9 files changed

+26
-18
lines changed

9 files changed

+26
-18
lines changed

buildspec_integ.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ phases:
1010
commands:
1111
# Enforce STS regional endpoints
1212
- export AWS_STS_REGIONAL_ENDPOINTS=regional
13-
- export CW_INTEG_VALIDATOR_IMAGE=${AWS_ACCOUNT}.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator:latest
14-
- export S3_INTEG_VALIDATOR_IMAGE=${AWS_ACCOUNT}.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator:latest
13+
- export CW_INTEG_VALIDATOR_IMAGE=${AWS_ACCOUNT}.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator
14+
- export S3_INTEG_VALIDATOR_IMAGE=${AWS_ACCOUNT}.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator
1515
# Get the default credentials and set as environment variables
1616
- 'CREDS=`curl 169.254.170.2$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI`'
1717
- 'export AWS_ACCESS_KEY_ID=`echo $CREDS | jq -r .AccessKeyId`'

integ/run-integ.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ $env:FLUENT_BIT_IMAGE = $FluentBitImage
7575
$env:TAG = -join ((65..90) + (97..122) | Get-Random -Count 10 | % {[char]$_})
7676
# AWS_FOR_FLUENT_BIT_CONTAINER_NAME is the name for the fluent-bit container ran for each service.
7777
$env:AWS_FOR_FLUENT_BIT_CONTAINER_NAME = "aws-for-fluent-bit-$($env:TAG)"
78-
$env:CW_INTEG_VALIDATOR_IMAGE = "906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator:latest"
79-
$env:S3_INTEG_VALIDATOR_IMAGE = "906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator:latest"
78+
$env:CW_INTEG_VALIDATOR_IMAGE = "906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator-windows"
79+
$env:S3_INTEG_VALIDATOR_IMAGE = "906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator-windows"
8080

8181
# Windows specific settings.
8282
$env:ARCHITECTURE= "x86-64"
Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
1-
## CW Validator Image
1+
## S3 Validator Image
22

33
The S3 Validator image exists in our account as:
44

55
```
6-
906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator:latest
6+
906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator:arm64
7+
906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator:x86_64
8+
906394416424.dkr.ecr.us-west-2.amazonaws.com/s3-integ-validator-windows:x86_64
79
```
810

911
If we need to perform a change or dependency update, build the image and push it to the account with that name.
1012

11-
The image is set as an env var `S3_INTEG_VALIDATOR_IMAGE` in:
13+
The base image URI is set as an env var `S3_INTEG_VALIDATOR_IMAGE` in:
1214
- Linux: buildspec_integ.yml
13-
- Windows: integ/run-integ.ps1
15+
- Windows: run-integ.ps1
16+
17+
The tag is the value of `${ARCHITECTURE}`
1418

1519
The env var is used in the `docker-compose.validate-and-clean.yml` files for firehose, kinesis, and S3 tests.

integ/test_cloudwatch/docker-compose.validate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: "2"
22

33
services:
44
cloudwatch_validator:
5-
image: ${CW_INTEG_VALIDATOR_IMAGE}
5+
image: ${CW_INTEG_VALIDATOR_IMAGE}:${ARCHITECTURE}
66
environment:
77
- "AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
88
- "AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"

integ/test_firehose/docker-compose.validate-and-clean-s3.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: "2"
22

33
services:
44
validate-s3:
5-
image: ${S3_INTEG_VALIDATOR_IMAGE}
5+
image: ${S3_INTEG_VALIDATOR_IMAGE}:${ARCHITECTURE}
66
environment:
77
- "AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
88
- "AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"

integ/test_kinesis/docker-compose.validate-and-clean-s3.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: "2"
22

33
services:
44
validate-s3:
5-
image: ${S3_INTEG_VALIDATOR_IMAGE}
5+
image: ${S3_INTEG_VALIDATOR_IMAGE}:${ARCHITECTURE}
66
environment:
77
- "AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
88
- "AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"

integ/test_s3/docker-compose.validate-s3-multipart.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: "2"
22

33
services:
44
validate-s3-multipart:
5-
image: ${S3_INTEG_VALIDATOR_IMAGE}
5+
image: ${S3_INTEG_VALIDATOR_IMAGE}:${ARCHITECTURE}
66
environment:
77
- "AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
88
- "AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"

integ/test_s3/docker-compose.validate-s3-putobject.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: "2"
22

33
services:
44
validate-s3-put-object:
5-
image: ${S3_INTEG_VALIDATOR_IMAGE}
5+
image: ${S3_INTEG_VALIDATOR_IMAGE}:${ARCHITECTURE}
66
environment:
77
- "AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
88
- "AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"

integ/validate_cloudwatch/updating_validator_image.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,17 @@
33
The CW Validator image exists in our account as:
44

55
```
6-
906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator:latest
6+
906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator:arm64
7+
906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator:x86_64
8+
906394416424.dkr.ecr.us-west-2.amazonaws.com/cw-integ-validator-windows:x86_64
79
```
810

9-
If we need to perform a change or dependency update, build the image and push it to the account with that name.
11+
If we need to perform a change or dependency update, build the image and push it to the account with that name.
1012

11-
The image is set as an env var `CW_INTEG_VALIDATOR_IMAGE` in:
13+
The base image URI is set as an env var `CW_INTEG_VALIDATOR_IMAGE` in:
1214
- Linux: buildspec_integ.yml
13-
- Windows: integ/run-integ.ps1
15+
- Windows: run-integ.ps1
1416

15-
The env var is used in `integ/test_cloudwatch/docker-compose.validate.yml`.
17+
The tag is the value of `${ARCHITECTURE}`
18+
19+
The env var is used in the `docker-compose.validate-and-clean.yml` files for firehose, kinesis, and S3 tests.

0 commit comments

Comments
 (0)