Remove demo platform unit tests (#1832)

Each of the libraries included in CSDK has its own unit tests.
The tests in this repo are for the demos' platform integration; these are not
nessesary for demo code, and require large effort to update when updating and
adding demos.

Author: archigup

.github/workflows/ci.yml

@@ -45,7 +45,7 @@ jobs:
           make -C build/ help | grep demo | tr -d '. ' | xargs make -C build/
           make -C demos/jobs/jobs_demo_mosquitto
   build-check-demos-cpp:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: Clone This Repo
         uses: actions/checkout@v2
@@ -88,39 +88,6 @@ jobs:
       - name: Build Demos
         run: |
           make -C build/ help | grep demo | tr -d '. ' | xargs make -C build/
-  build-check-system-tests:
-    runs-on: ubuntu-18.04
-    steps:
-      - name: Clone This Repo
-        uses: actions/checkout@v2
-        with:
-          submodules: recursive
-      - name: Configure CMake build
-        run: |
-          curl https://cmake.org/files/v3.2/cmake-3.2.0-Linux-x86_64.tar.gz -o cmake.tar.gz
-          tar -xf cmake.tar.gz
-          mkdir build && cd build
-          ../cmake-3.2.0-Linux-x86_64/bin/cmake .. \
-          -G "Unix Makefiles" \
-          -DCMAKE_BUILD_TYPE=Release \
-          -DBUILD_TESTS=1 \
-          -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror' \
-          -DAWS_IOT_ENDPOINT="aws-iot-endpoint" \
-          -DBROKER_ENDPOINT="broker-endpoint" \
-          -DCLIENT_CERT_PATH="cert/path" \
-          -DROOT_CA_CERT_PATH="cert/path" \
-          -DCLIENT_PRIVATE_KEY_PATH="key/path" \
-          -DCLIENT_IDENTIFIER="ci-identifier" \
-          -DTHING_NAME="thing-name" \
-          -DS3_PRESIGNED_GET_URL="get-url" \
-          -DS3_PRESIGNED_PUT_URL="put-url" \
-          -DCLAIM_CERT_PATH="cert/path" \
-          -DCLAIM_PRIVATE_KEY_PATH="key/path" \
-          -DPROVISIONING_TEMPLATE_NAME="template-name" \
-          -DDEVICE_SERIAL_NUMBER="00000" \
-          -DCSR_SUBJECT_NAME="CN=Fleet Provisioning Demo"
-      - name: Build System Tests
-        run: make -C build/ help | grep system | tr -d '. ' | xargs make -C build/
   build-check-install:
     runs-on: ubuntu-18.04
     steps:
@@ -134,7 +101,7 @@ jobs:
           tar -xf cmake.tar.gz
           mkdir build && cd build
           ../cmake-3.2.0-Linux-x86_64/bin/cmake .. \
-          -DBUILD_DEMOS=0 -DBUILD_TESTS=0 \
+          -DBUILD_DEMOS=0 \
           -DCSDK_HEADER_INSTALL_PATH="$PWD/../shared-libs-headers-install-dir" -DCSDK_LIB_INSTALL_PATH="$PWD/../shared-libs-install-dir"
       - name: Install shared libraries and verify custom install location
         run: |
@@ -154,7 +121,7 @@ jobs:
           cd build
           ../cmake-3.2.0-Linux-x86_64/bin/cmake .. \
           -DBUILD_SHARED_LIBRARIES=OFF \
-          -DBUILD_DEMOS=0 -DBUILD_TESTS=0 \
+          -DBUILD_DEMOS=0 \
           -DCSDK_HEADER_INSTALL_PATH="$PWD/../static-libs-headers-install-dir" -DCSDK_LIB_INSTALL_PATH="$PWD/../static-libs-install-dir"
       - name: Install static libraries and verify custom install location
         run: |
@@ -195,58 +162,6 @@ jobs:
             fi
           # Each line of install_manifest.txt contains the location of an installed library or header
           done <install_manifest.txt
-  unittest:
-    runs-on: ubuntu-18.04
-    steps:
-      - name: Clone This Repo
-        uses: actions/checkout@v2
-        with:
-          submodules: recursive
-      - name: Download CMake 3.2.0
-        run: |
-          curl https://cmake.org/files/v3.2/cmake-3.2.0-Linux-x86_64.tar.gz -o cmake.tar.gz
-          tar -xf cmake.tar.gz
-          mkdir build
-          cmake-3.2.0-Linux-x86_64/bin/cmake . -Bbuild/ \
-          -G "Unix Makefiles" \
-          -DBUILD_TESTS=1 \
-          -DCMAKE_BUILD_TYPE=Debug \
-          -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG'
-          make -C build/ help | grep utest | tr -d '. ' | xargs make -C build/
-      - name: Build Unit Tests
-        run: |
-          sudo apt-get install -y lcov
-          make -C build/ help | grep utest | tr -d '. ' | xargs make -C build/
-      - name: Run ctest
-        run: |
-          cd build/
-          ctest -E system --output-on-failure
-          cd ..
-      - name: Run Coverage
-        run: |
-          make -C build/ coverage
-          declare -a EXCLUDE=("\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*3rdparty\*" "\*netdb\*" "*openssl/*")
-          echo ${EXCLUDE[@]} | xargs lcov --rc lcov_branch_coverage=1 -r build/coverage.info -o build/coverage.info
-          lcov --rc lcov_branch_coverage=1 --list build/coverage.info
-      - name: Check Coverage
-        env:
-          MIN_COVERAGE: 100
-        run: |
-          LINE_COVERAGE=$(lcov --list build/coverage.info | tail -n 1 | cut -d '|' -f 2 | sed -n "s/\([^%]*\)%.*/\1/p")
-          BRANCH_COVERAGE=$(lcov --rc lcov_branch_coverage=1 --list build/coverage.info | tail -n 1 | cut -d '|' -f 4 | sed -n "s/\([^%]*\)%.*/\1/p")
-          RESULT=0
-          echo "Required line and branch coverages: $MIN_COVERAGE"
-          echo "Line coverage:   $LINE_COVERAGE"
-          if [[ $(echo "$LINE_COVERAGE < $MIN_COVERAGE" | bc) -ne 0 ]]; then
-            echo "Line Coverage is too low."
-            RESULT=1
-          fi
-          echo "Branch coverage: $BRANCH_COVERAGE"
-          if [[ $(echo "$BRANCH_COVERAGE < $MIN_COVERAGE" | bc) -ne 0 ]]; then
-            echo "Branch Coverage is too low."
-            RESULT=1
-          fi
-          exit $RESULT
   complexity:
     runs-on: ubuntu-18.04
     steps:
@@ -305,7 +220,7 @@ jobs:
             exit 0
           fi
   doxygen:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:
@@ -371,7 +286,7 @@ jobs:
           include-file-types: .c,.h,.dox
           allowlist-file: ./.github/links_allowlist.txt
   verify-manifest:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:

CMakeLists.txt

@@ -32,9 +32,6 @@ set(3RDPARTY_DIR "${MODULES_DIR}/3rdparty" CACHE INTERNAL "3rdparty libraries ro
 include( "demos/logging-stack/logging.cmake" )
 
 # Configure options to always show in CMake GUI.
-option( BUILD_TESTS
-        "Set this to ON to build test executables."
-        OFF )
 option( BUILD_DEMOS
         "Set this to ON to build demo executables."
         ON )
@@ -79,25 +76,6 @@ if(DEFINED ENV{PWD})
     endif()
 endif()
 
-# Build the tests if flag enabled.
-if(BUILD_TESTS)
-    enable_testing()
-    include(${ROOT_DIR}/tools/cmock/cmock_dependencies.cmake)
-
-    # Create a list for each unit test target.
-    set(utest_targets
-        openssl_utest sockets_utest
-        plaintext_utest clock_utest ota_pal_posix_utest)
-
-    # Add a target for running coverage on tests.
-    add_custom_target(coverage
-        COMMAND ${CMAKE_COMMAND} -DROOT_DIR=${ROOT_DIR}
-        -P ${CMAKE_SOURCE_DIR}/tools/cmock/coverage.cmake
-        DEPENDS cmock unity ${utest_targets}
-        WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-    )
-endif()
-
 include(GNUInstallDirs)
 
 # Try installing to /opt if the directory exists, or use the home directory otherwise.
@@ -141,21 +119,13 @@ include( tools/cmake/utility.cmake )
 # Make THING_NAME an alias for CLIENT_IDENTIFIER
 set_alias( "CLIENT_IDENTIFIER" ALIASES "THING_NAME" )
 
-if(BUILD_TESTS)
-    # Add build configuration for integration tests.
-    add_subdirectory( integration-test )
-endif()
 if(BUILD_DEMOS)
     # Add build configuration for demos.
     add_subdirectory( demos )
 endif()
 
 if(DOWNLOAD_CERTS)
-    if(BUILD_TESTS)
-        set(CERT_DOWNLOAD_DIR ${SYSTEM_TEST_DIR}/certificates)
-    else()
-        set(CERT_DOWNLOAD_DIR ${DEMOS_DIR}/certificates)
-    endif()
+    set(CERT_DOWNLOAD_DIR ${DEMOS_DIR}/certificates)
     file(MAKE_DIRECTORY ${CERT_DOWNLOAD_DIR})
     # Download the Amazon Root CA certificate.
     message( "Downloading the Amazon Root CA certificate..." )
@@ -166,8 +136,4 @@ if(DOWNLOAD_CERTS)
     # Copy certificates to the build directory.
     file(COPY "${CERT_DOWNLOAD_DIR}"
          DESTINATION ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
-    if(BUILD_TESTS)
-        file(COPY "${CERT_DOWNLOAD_DIR}"
-             DESTINATION ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/tests)
-    endif()
 endif()

docs/utest_guide.md

@@ -8,7 +8,7 @@ description: |-
   See dependencies for included libraries."
 dependencies:
   - name: "coreMQTT"
-    version: "v2.1.0"
+    version: "v2.1.1"
     repository:
       type: "git"
       url: "https://github.com/FreeRTOS/coreMQTT"