Remove useless check for valid certificate

If certificate check fails, SSL_Connect will fail, thus the removed code will
not run. It would only runs when successful. That function is meant to check the
error code when there is a certificate validation issue.

SSL_get_verify_result is being used incorrectly here; it is intended to get
the validation error reason when SSL_Connect fails, and that failure is due to
an invalid certificate.

Author: archigup

platform/posix/transport/src/openssl_posix.c

@@ -241,7 +241,7 @@ static OpensslStatus_t tlsHandshake( const ServerInfo_t * pServerInfo,
                                      const OpensslCredentials_t * pOpensslCredentials )
 {
     OpensslStatus_t returnStatus = OPENSSL_SUCCESS;
-    int32_t sslStatus = -1, verifyPeerCertStatus = X509_V_OK;
+    int32_t sslStatus = -1;
 
     /* Validate the hostname against the server's certificate. */
     sslStatus = SSL_set1_host( pOpensslParams->pSsl, pServerInfo->pHostName );
@@ -282,19 +282,6 @@ static OpensslStatus_t tlsHandshake( const ServerInfo_t * pServerInfo,
         }
     }
 
-    /* Verify X509 certificate from peer. */
-    if( returnStatus == OPENSSL_SUCCESS )
-    {
-        verifyPeerCertStatus = ( int32_t ) SSL_get_verify_result( pOpensslParams->pSsl );
-
-        if( verifyPeerCertStatus != X509_V_OK )
-        {
-            LogError( ( "SSL_get_verify_result failed to verify X509 "
-                        "certificate from peer." ) );
-            returnStatus = OPENSSL_HANDSHAKE_FAILED;
-        }
-    }
-
     return returnStatus;
 }