changes to actions

Author: 0marperez

.github/actions/artifact-size-metrics/build-and-upload/action.yml

@@ -2,19 +2,21 @@ name: Calculate Artifact Size
 description: Calculates size for JVM artifacts
 
 inputs:
-  artifact-dirs:
-    description: List of directories for which artifact sizes will be calculated
-    required: true
-    # TODO: Additional inputs
+  upload:
+    description: Whether the metrics should be uploaded to S3/Cloudwatch
+  release_metrics:
+    description: Whether the metrics are coming from a release build
 
 runs:
   using: composite
   steps:
-    - name: Checkout repository
-      uses: actions/checkout@v4
-
     - name: Calculate artifact sizes
       shell: bash
+      env:
+        GITHUB_REPOSITORY: ${{ github.repository }}
+        IDENTIFIER: ${{ github.ref_name }}
+        UPLOAD: ${{ inputs.upload }}
+        RELEASE_METRICS: ${{ inputs.release_metrics }}
       run: |
-        chmod +x ./src/main.sh
-        ./src/main.sh
+        chmod +x ../utils/build-and-upload/main.sh
+        ../utils/build-and-upload/main.sh

.github/actions/artifact-size-metrics/download-and-process/action.yml

@@ -1,102 +1,66 @@
-name: Download and process artifact size metrics
-description: TODO
+name: Process artifact size metrics
+description: Compares artifact size metrics, leaves a comment, and fails if a size increase of ≥5% is detected.
 
 inputs:
   download:
-    description: TODO
-    default: "false"
-    # TODO: Additional inputs
+    description: Whether the artifact size metrics should be downloaded from S3
 
 runs:
   using: composite
   steps:
     - name: Download and process artifact size metrics
+      description: Compares artifact size metrics and sets LARGE_DIFF to true if a size increase of ≥5% is detected.
       shell: bash
+      env:
+        DOWNLOAD: ${{ inputs.download }}
+        GITHUB_REPOSITORY: ${{ github.repository }}
+        IDENTIFIER: ${{ github.ref_name }}
       run: |
-        chmod +x ./src/main.sh
-        chmod +x ./src/s3.sh
-        chmod +x ./src/compare.sh
-        chmod +x ./src/comment.sh
-        
-        ./src/main.sh
+        chmod +x ../utils/download-and-process/main.sh        
+        ../utils/download-and-process/main.sh
 
-    - name: Post artifact analysis comment # TODO: MOVE TO SCRIPT IF POSSIBLE
+    - name: Comment artifact size metrics comparison
+      if: github.event_name == 'pull_request'
       uses: actions/github-script@v7
       with:
         script: |
-          const fs = require('node:fs')
-          const prNumber = context.issue.number ?? process.env.SDK_PR # TOSO - CHANGE - THIS WON'T WORK FOR EXTERNAL CONTRIBUTORS BTW - IF EXTERNAL CONTRIBUTOR JUST FAIL
-          const prInfo = await github.rest.pulls.get({
+           const fs = require('node:fs')
+
+          // Read the artifact size metrics comparison
+          const comparison = fs.readFileSync('build/reports/metrics/artifact-analysis.md', 'utf8')
+    
+          // Get PR ID
+          const { data: pullRequest } = await github.rest.pulls.get({
             owner: context.repo.owner,
             repo: context.repo.repo,
-            pull_number: prNumber
+            pull_number: context.issue.number
           })
-
-          const hasAcknowledgeLabel = prInfo.data.labels.some(label => label.name === 'acknowledge-artifact-size-increase')
-
-          const getComments = `
-            query { 
-              repository(owner:"${context.repo.owner}", name:"${context.repo.repo}"){
-                pullRequest(number: ${prNumber}) {
-                  id
-                  comments(last:100) {
-                    nodes {
-                      id
-                      body
-                      author {
-                        login
-                      }
-                      isMinimized
-                    }
-                  }
-                }
-              }
-            }`
-
-          const response = await github.graphql(getComments)
-          const comments = response.repository.pullRequest.comments.nodes
-
-          // Minimize outdated artifact-size comments
-          const mutations = comments
-            .filter(comment => comment.author.login == 'github-actions' && !comment.isMinimized && comment.body.startsWith('Affected Artifacts'))
-            .map(comment =>
-              github.graphql(`mutation {
-                minimizeComment(input:{subjectId:"${comment.id}", classifier:OUTDATED}){
-                  clientMutationId
-                }
-              }`)
-            )
-          await Promise.all(mutations)
-
-          const comment = fs.readFileSync('build/reports/metrics/artifact-analysis.md', 'utf8')
-
-          // Create a new comment with the latest artifact analysis
-          const writeComment = `mutation {
-            addComment(input:{body:"""${comment}""", subjectId:"${response.repository.pullRequest.id}"}){
-              commentEdge {
-                node {
-                  id
-                }
-              }
-            }}`
-          const addCommentResponse = await github.graphql(writeComment)
-          const newCommentId = addCommentResponse.addComment.commentEdge.node.id
-
-          // Minimize the newly-created comment if artifact size increase is acknowledged
-          if (hasAcknowledgeLabel) {
-            await github.graphql(`mutation {
-              minimizeComment(input:{subjectId:"${newCommentId}", classifier:RESOLVED}){
-                clientMutationId
+          const pullRequestId = pullRequest.node_id
+    
+          // Add the comment
+          const addCommentResponse = await github.graphql(`
+            mutation {
+              addComment(input: {body: """${comparison}""", subjectId: "${pullRequestId}"}) {
+                commentEdge { node { id } }
               }
-            }`)
-          }
+            }
+          `)
+    
+          const commentId = addCommentResponse.addComment.commentEdge.node.id
+    
+          // Minimize the comment
+          await github.graphql(`
+            mutation {
+              minimizeComment(input: {subjectId: "${commentId}", classifier: RESOLVED}) { }
+            }
+          `)
 
-    - name: Fail if large size increase
-      shell: bash
+    - name: Large size increase?
       if: ${{ !contains(github.event.pull_request.labels.*.name, 'acknowledge-artifact-size-increase') }}
+      shell: bash
       run: |
         if [ "$LARGE_DIFF" == "true" ]; then
-            echo An artifact increased in size by more than allowed or a new artifact was created.
-            echo If this is expected please add the 'acknowledge-artifact-size-increase' label to this pull request.
+            echo "An artifact has increased in size by more than 5%.
+            If this is expected, please add the acknowledge-artifact-size-increase label to this pull request."
             exit 1
         fi