Skip to content

Commit 19f22e4

Browse files
committed
pr review fixes
1 parent 432b581 commit 19f22e4

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

.github/workflows/run-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
PATCH_NUMBER=${PATCH%%[^0-9]*}
4646
PATCH_SUFFIX=${PATCH#$PATCH_NUMBER}
4747
((PATCH_NUMBER++))
48-
echo "NEW_VERSION=$MAJOR.$MINOR.$PATCH_NUMBER$SUFFIX" >> "$GITHUB_OUTPUT"
48+
echo "NEW_VERSION=$MAJOR.$MINOR.$PATCH_NUMBER$PATCH_SUFFIX" >> "$GITHUB_OUTPUT"
4949
5050
- name: Create new version tag
5151
env:

README.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ version that is being released.
2020

2121
To cut a new release:
2222

23-
1. Go to this repos GitHub actions.
23+
1. Go to this repo's GitHub actions.
2424
2. Locate the release workflow.
2525
3. Specify whether the release will be of a kn variant (used for Kotlin Native development).
2626
4. If you're doing a minor or major version bump, specify the version override (including "-kn" if a kn variant).
@@ -29,6 +29,19 @@ To cut a new release:
2929
The workflow will create a tag, push it to this repo and then start a
3030
CodeBuild release job hosted in the shared tools account (e.g. `publish-aws-kotlin-repo-tools`).
3131

32+
<details>
33+
<summary>Old manual release instructions</summary>
34+
35+
1. Create a new tag, e.g. `git tag x.y.z`.
36+
2. Push the tag up `git push origin x.y.z`.
37+
3. Go to the CodeBuild release job hosted in the shared tools account (e.g. `publish-aws-kotlin-repo-tools`).
38+
4. Start a build with overrides.
39+
5. Under `Source` connect your GitHub account (Under `Source` -> `Connection Status` you should see "You are connected to GitHub").
40+
6. Specify the tag you created under `Source Version`.
41+
7. Start the build.
42+
43+
</details>
44+
3245
## Development
3346

3447
### Local development

0 commit comments

Comments
 (0)