misc: stop using JReleaser environment variables in configurePublishing (#146)

Author: lauzadis

build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/Publish.kt

@@ -32,6 +32,7 @@ private const val SIGNING_PASSWORD_PROP = "signingPassword"
 private const val SONATYPE_USERNAME_PROP = "sonatypeUsername"
 private const val SONATYPE_PASSWORD_PROP = "sonatypePassword"
 
+// TODO Remove JReleaser environment variables when smithy-kotlin + aws-crt-kotlin are migrated to custom Sonatype integration
 private object EnvironmentVariables {
     const val GROUP_ID = "JRELEASER_PROJECT_JAVA_GROUP_ID"
     const val MAVEN_CENTRAL_USERNAME = "JRELEASER_MAVENCENTRAL_USERNAME"
@@ -42,6 +43,9 @@ private object EnvironmentVariables {
     const val GENERIC_TOKEN = "JRELEASER_GENERIC_TOKEN"
 }
 
+private const val SIGNING_PUBLIC_KEY = "SIGNING_KEY"
+private const val SIGNING_SECRET_KEY = "SIGNING_PASSWORD"
+
 internal val ALLOWED_PUBLICATION_NAMES = setOf(
     "common",
     "jvm",
@@ -240,8 +244,8 @@ fun Project.configurePublishing(repoName: String, githubOrganization: String = "
             }
         }
 
-        val secretKey = System.getenv(EnvironmentVariables.GPG_SECRET_KEY)
-        val passphrase = System.getenv(EnvironmentVariables.GPG_PASSPHRASE)
+        val secretKey = System.getenv(SIGNING_PUBLIC_KEY)
+        val passphrase = System.getenv(SIGNING_SECRET_KEY)
 
         if (!secretKey.isNullOrBlank() && !passphrase.isNullOrBlank()) {
             apply(plugin = "signing")
@@ -255,6 +259,8 @@ fun Project.configurePublishing(repoName: String, githubOrganization: String = "
             tasks.withType<AbstractPublishToMaven>().configureEach {
                 mustRunAfter(signingTasks)
             }
+        } else {
+            logger.info("Skipping signing configuration, $SIGNING_PUBLIC_KEY or $SIGNING_SECRET_KEY are not set")
         }
     }
 

build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/publishing/SonatypeCentralPortalWaitForPublicationTask.kt

@@ -24,7 +24,7 @@ abstract class SonatypeCentralPortalWaitForPublicationTask : DefaultTask() {
     abstract val deploymentId: Property<String>
 
     @Option(option = "deploymentId", description = "Deployment ID to wait for")
-    fun setDeploymentId(id: String) {
+    fun setDeploymentIdFromOption(id: String) {
         deploymentId.set(id)
     }