Skip to content

Commit d96e464

Browse files
committed
jreleaser fixes
1 parent 0631e5d commit d96e464

File tree

1 file changed

+2
-11
lines changed
  • build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl

1 file changed

+2
-11
lines changed

build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/Publish.kt

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,6 @@ fun Project.configureJReleaser() {
313313
val requiredVariables = listOf(
314314
EnvironmentVariables.MAVEN_CENTRAL_USERNAME,
315315
EnvironmentVariables.MAVEN_CENTRAL_TOKEN,
316-
EnvironmentVariables.GPG_PASSPHRASE,
317-
EnvironmentVariables.GPG_PUBLIC_KEY,
318-
EnvironmentVariables.GPG_SECRET_KEY,
319316
EnvironmentVariables.GENERIC_TOKEN,
320317
)
321318

@@ -342,13 +339,6 @@ fun Project.configureJReleaser() {
342339
version = providers.gradleProperty("sdkVersion").get()
343340
}
344341

345-
// FIXME We're currently signing the artifacts twice. Once using the logic in configurePublishing above,
346-
// and the second time during JReleaser's signing stage.
347-
signing {
348-
active = Active.ALWAYS
349-
armored = true
350-
}
351-
352342
// JReleaser requires a releaser to be configured even though we don't use it.
353343
// https://github.com/jreleaser/jreleaser/discussions/1725#discussioncomment-10674529
354344
release {
@@ -367,7 +357,8 @@ fun Project.configureJReleaser() {
367357
maven {
368358
mavenCentral {
369359
create("maven-central") {
370-
active = Active.ALWAYS // the Maven deployer default is ALWAYS, but MavenCentral is NEVER
360+
active = Active.ALWAYS // The Maven deployer default is ALWAYS, but MavenCentral is NEVER
361+
sign = false // Signing is done when publishing, see the 'configurePublishing' function
371362
url = "https://central.sonatype.com/api/v1/publisher"
372363
stagingRepository(rootProject.layout.buildDirectory.dir("m2").get().toString())
373364
artifacts {

0 commit comments

Comments
 (0)