Skip to content

Commit e347e3a

Browse files
committed
Revert "Enable warnings as errors"
This reverts commit e423548.
1 parent 79b5a61 commit e347e3a

File tree

5 files changed

+4
-14
lines changed

5 files changed

+4
-14
lines changed

build-plugins/smithy-build/src/test/kotlin/aws/sdk/kotlin/gradle/codegen/GenerateSmithyBuildTaskTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import aws.sdk.kotlin.gradle.codegen.dsl.SmithyBuildPluginSettings
88
import aws.sdk.kotlin.gradle.codegen.dsl.SmithyProjection
99
import aws.sdk.kotlin.gradle.codegen.tasks.GenerateSmithyBuild
1010
import aws.sdk.kotlin.gradle.codegen.tasks.json
11-
import org.gradle.kotlin.dsl.register
11+
import org.gradle.kotlin.dsl.create
1212
import org.gradle.testfixtures.ProjectBuilder
1313
import software.amazon.smithy.model.node.Node
1414
import kotlin.test.Test
@@ -19,7 +19,7 @@ class GenerateSmithyBuildTaskTest {
1919
@Test
2020
fun testDefaults() {
2121
val testProj = ProjectBuilder.builder().build()
22-
val task = testProj.tasks.register<GenerateSmithyBuild>("generateSmithyBuild").get()
22+
val task = testProj.tasks.create<GenerateSmithyBuild>("generateSmithyBuild")
2323
assertEquals(task.generatedOutput.get().asFile.path, testProj.layout.buildDirectory.file("smithy-build.json").get().asFile.path)
2424
}
2525

@@ -42,9 +42,9 @@ class GenerateSmithyBuildTaskTest {
4242
plugins["plugin1"] = testPlugin
4343
},
4444
)
45-
val task = testProj.tasks.register<GenerateSmithyBuild>("generateSmithyBuild") {
45+
val task = testProj.tasks.create<GenerateSmithyBuild>("generateSmithyBuild") {
4646
smithyBuildConfig.set(smithyProjections.json)
47-
}.get()
47+
}
4848

4949
task.generateSmithyBuild()
5050
assertTrue(task.generatedOutput.get().asFile.exists())

build.gradle.kts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
33
* SPDX-License-Identifier: Apache-2.0
44
*/
5-
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
6-
75
plugins {
86
`maven-publish`
97
alias(libs.plugins.kotlin.jvm) apply false
@@ -18,11 +16,6 @@ if (s3Url == null) logger.warn("S3 repository not configured, missing S3 url")
1816
allprojects {
1917
// Enables running `./gradlew allDeps` to get a comprehensive list of dependencies for every subproject
2018
tasks.register<DependencyReportTask>("allDeps") { }
21-
tasks.withType<KotlinCompile> {
22-
compilerOptions {
23-
allWarningsAsErrors = true
24-
}
25-
}
2619
}
2720

2821
subprojects {

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/CopyrightHeaderRule.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class CopyrightHeaderRule : Rule(RuleId("copyright-header"), About()) {
2222
""".trimIndent()
2323
}
2424

25-
@Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
2625
override fun beforeVisitChildNodes(
2726
node: ASTNode,
2827
autoCorrect: Boolean,

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/ExpressionBodyRule.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import org.jetbrains.kotlin.psi.KtNamedFunction
1212
import org.jetbrains.kotlin.psi.KtReturnExpression
1313

1414
class ExpressionBodyRule : Rule(RuleId("expression-body"), About()) {
15-
@Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
1615
override fun beforeVisitChildNodes(
1716
node: ASTNode,
1817
autoCorrect: Boolean,

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/MultilineIfElseBlockRule.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import com.pinterest.ktlint.rule.engine.core.api.RuleId
1010
import org.jetbrains.kotlin.com.intellij.lang.ASTNode
1111

1212
class MultilineIfElseBlockRule : Rule(RuleId("multiline-if-else-block"), About()) {
13-
@Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
1413
override fun beforeVisitChildNodes(
1514
node: ASTNode,
1615
autoCorrect: Boolean,

0 commit comments

Comments
 (0)