Enable warnings as errors

Author: lauzadis

build-plugins/smithy-build/src/test/kotlin/aws/sdk/kotlin/gradle/codegen/GenerateSmithyBuildTaskTest.kt

@@ -8,7 +8,7 @@ import aws.sdk.kotlin.gradle.codegen.dsl.SmithyBuildPluginSettings
 import aws.sdk.kotlin.gradle.codegen.dsl.SmithyProjection
 import aws.sdk.kotlin.gradle.codegen.tasks.GenerateSmithyBuild
 import aws.sdk.kotlin.gradle.codegen.tasks.json
-import org.gradle.kotlin.dsl.create
+import org.gradle.kotlin.dsl.register
 import org.gradle.testfixtures.ProjectBuilder
 import software.amazon.smithy.model.node.Node
 import kotlin.test.Test
@@ -19,7 +19,7 @@ class GenerateSmithyBuildTaskTest {
     @Test
     fun testDefaults() {
         val testProj = ProjectBuilder.builder().build()
-        val task = testProj.tasks.create<GenerateSmithyBuild>("generateSmithyBuild")
+        val task = testProj.tasks.register<GenerateSmithyBuild>("generateSmithyBuild").get()
         assertEquals(task.generatedOutput.get().asFile.path, testProj.layout.buildDirectory.file("smithy-build.json").get().asFile.path)
     }
 
@@ -42,9 +42,9 @@ class GenerateSmithyBuildTaskTest {
                 plugins["plugin1"] = testPlugin
             },
         )
-        val task = testProj.tasks.create<GenerateSmithyBuild>("generateSmithyBuild") {
+        val task = testProj.tasks.register<GenerateSmithyBuild>("generateSmithyBuild") {
             smithyBuildConfig.set(smithyProjections.json)
-        }
+        }.get()
 
         task.generateSmithyBuild()
         assertTrue(task.generatedOutput.get().asFile.exists())

build.gradle.kts

@@ -2,6 +2,8 @@
  * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+
 plugins {
     `maven-publish`
     alias(libs.plugins.kotlin.jvm) apply false
@@ -16,6 +18,11 @@ if (s3Url == null) logger.warn("S3 repository not configured, missing S3 url")
 allprojects {
     // Enables running `./gradlew allDeps` to get a comprehensive list of dependencies for every subproject
     tasks.register<DependencyReportTask>("allDeps") { }
+    tasks.withType<KotlinCompile> {
+        compilerOptions {
+            allWarningsAsErrors = true
+        }
+    }
 }
 
 subprojects {

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/CopyrightHeaderRule.kt

@@ -22,6 +22,7 @@ class CopyrightHeaderRule : Rule(RuleId("copyright-header"), About()) {
         """.trimIndent()
     }
 
+    @Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
     override fun beforeVisitChildNodes(
         node: ASTNode,
         autoCorrect: Boolean,

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/ExpressionBodyRule.kt

@@ -12,6 +12,7 @@ import org.jetbrains.kotlin.psi.KtNamedFunction
 import org.jetbrains.kotlin.psi.KtReturnExpression
 
 class ExpressionBodyRule : Rule(RuleId("expression-body"), About()) {
+    @Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
     override fun beforeVisitChildNodes(
         node: ASTNode,
         autoCorrect: Boolean,

ktlint-rules/src/main/kotlin/software/aws/ktlint/rules/MultilineIfElseBlockRule.kt

@@ -10,6 +10,7 @@ import com.pinterest.ktlint.rule.engine.core.api.RuleId
 import org.jetbrains.kotlin.com.intellij.lang.ASTNode
 
 class MultilineIfElseBlockRule : Rule(RuleId("multiline-if-else-block"), About()) {
+    @Deprecated("Marked for removal in Ktlint 2.0. Please implement interface RuleAutocorrectApproveHandler.")
     override fun beforeVisitChildNodes(
         node: ASTNode,
         autoCorrect: Boolean,