chore: fix emit-metrics integration with kat #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Mar 6, 2025
0marperez
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
Previously, the emit-metrics action attempted to verify kat was installed by executing
which katbut, unfortunately,whichis not installed on GH action runners by default and installing it is unnecessary overhead. Thus, replaced that check with a simplekat versionwhich will achieve the same outcome without relying onwhich.Also updated the setup-kat action to emit more information about paths (should assist in future debugging) and to silence the AWS CLI progress meter (which is less useful in headless environments anyway).
Also upgraded our invocations of
actions/cache@v2tov4sincev2is now EOL.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.