feat: Kotlin/Native Windows compilation #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Jun 16, 2025
|
|
||
| if (NATIVE_ENABLED) { | ||
| if (hasApple) { | ||
| if ((hasApple || hasDesktop) && HostManager.hostIsMac) { |
Member
There was a problem hiding this comment.
Was the hasDesktop addition necessary here? IIRC we don't use the "desktop" source set anywhere. Was this just for correctness?
Contributor
Author
There was a problem hiding this comment.
Yes I was condensing the boolean logic from L124-130. If we have no plans to use desktop in the future I can remove this and related declarations.
Member
There was a problem hiding this comment.
We can leave it in place for now and look at simplifying after development is complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-kotlin#229
Description of changes:
This change adds support for Kotlin/Native Windows compilation by configuring the
mingwX64target when applicable.This change also removes most support for cross-compilation as it presents too many challenges during development while still not providing a streamlined way to test the built binaries. Kotlin/Native targets will now build only on a host with a matching OS (although different architectures may still be cross-compiled on a single host).
Companion PR: aws/aws-crt-kotlin#152
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.