Skip to content

Commit b663326

Browse files
lausdahlCoshUS
andauthored
Added maven dependency flag to include groupIds when copying dependen… (#195)
* Added maven dependency flag to include groupIds when copying dependencies * updated java maven dependency test expected results * update java maven unit test Co-authored-by: Cosh_ <[email protected]>
1 parent 0caa19a commit b663326

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

aws_lambda_builders/workflows/java_maven/maven.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def build(self, scratch_dir):
3434
raise MavenExecutionError(message=stdout.decode("utf8").strip())
3535

3636
def copy_dependency(self, scratch_dir):
37-
args = ["dependency:copy-dependencies", "-DincludeScope=compile"]
37+
args = ["dependency:copy-dependencies", "-DincludeScope=compile", "-Dmdep.prependGroupId=true"]
3838
ret_code, stdout, _ = self._run(args, scratch_dir)
3939

4040
if ret_code != 0:

tests/integration/workflows/java_maven/test_java_maven.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_build_single_build_with_deps_resources_exclude_test_jars(self):
2828
expected_files = [
2929
p("aws", "lambdabuilders", "Main.class"),
3030
p("some_data.txt"),
31-
p("lib", "annotations-2.1.0.jar"),
31+
p("lib", "software.amazon.awssdk.annotations-2.1.0.jar"),
3232
]
3333
self.assert_artifact_contains_files(expected_files)
3434
self.assert_artifact_not_contains_file(p("lib", "junit-4.12.jar"))

tests/unit/workflows/java_maven/test_maven.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def test_copy_dependency(self):
6161
maven = SubprocessMaven(maven_binary=self.maven_binary, os_utils=self.os_utils)
6262
maven.copy_dependency(self.source_dir)
6363
self.os_utils.popen.assert_called_with(
64-
[self.maven_path, "dependency:copy-dependencies", "-DincludeScope=compile"],
64+
[self.maven_path, "dependency:copy-dependencies", "-DincludeScope=compile", "-Dmdep.prependGroupId=true"],
6565
cwd=self.source_dir,
6666
stderr=subprocess.PIPE,
6767
stdout=subprocess.PIPE,

0 commit comments

Comments
 (0)